Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deprecated package id #20

Open
Spokeek opened this issue Oct 23, 2023 · 7 comments · May be fixed by #25
Open

Handle deprecated package id #20

Spokeek opened this issue Oct 23, 2023 · 7 comments · May be fixed by #25

Comments

@Spokeek
Copy link

Spokeek commented Oct 23, 2023

I am having an edge case where I (think) I need to ignore some package id from a listing i have.

I'm having a vpm listing setup and i'm importing a github repository with the githubRepos option.

The issue i have is that within the release history of that package, there is two different ids listed.

The package i have an issue with is https://github.com/bdunderscore/modular-avatar
Before version 1.0.0, they have used the id "net.fushizen.modular-avatar" and now are using "nadena.dev.modular-avatar"

By that mean, the action is creating two separate entries for the package.

I guess some solutions would be to either be the following
- be able to ignore some entries by filtering some id
- be able to merge some id
- change the original package form to list previously used ids so we can merge their definition

Can i have your thoughts about this ?

Edit:

After discussion, i made a PR that will update the github repository fetch mechanism.

Now we filter the list of release by the latest release manifest package id.

If the other releases don't have the same package id, they are filtered.

@momo-the-monster
Copy link
Collaborator

Sure, you're welcome to modify this action to fit your needs!

@Spokeek
Copy link
Author

Spokeek commented Oct 23, 2023

I'm doing so at the moment. I'm technically taking another direction by allowing to list some remove vpm listing to integrate in mine so you could add packages, github repos, and vpm listings.

My point was also to see if there was an expected behavior when loading packages that have releases linking multiple ids. If you have information about that @momo-the-monster i would be glad making changes or a PR to reflect the thing.

@momo-the-monster
Copy link
Collaborator

We don't have any mechanisms in the core library for identifying a package which changed its id - the id is used as the core identifier for the package and is seen as a separate entity.

@Spokeek
Copy link
Author

Spokeek commented Oct 23, 2023

All right, i'll look to make a id collision based on a repositoryUrl so if the package id of the release is different than the latest id of the repository, i'll ignore it.

@momo-the-monster
Copy link
Collaborator

Sounds good!

@Spokeek Spokeek changed the title Have a way to ignore some deprecated package id from a listing Handle deprecated package id Oct 25, 2023
@Spokeek
Copy link
Author

Spokeek commented Oct 25, 2023

All right, PR ready, hopefully stays in the workflow.

That's a little slow process as it pulls the manifests one at the time, i don't know if that's a concern.

@Spokeek
Copy link
Author

Spokeek commented Nov 14, 2023

@momo-the-monster any news on potential community PR integration ?

@Spokeek Spokeek linked a pull request Dec 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants