Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for feedback #178

Open
vrischmann opened this issue Jan 24, 2025 · 6 comments
Open

Request for feedback #178

vrischmann opened this issue Jan 24, 2025 · 6 comments

Comments

@vrischmann
Copy link
Owner

Hello everyone,

I'd like to get feedback from users of zig-sqlite, if anyone happens to look at issues and sees this.

I recently worked on improving the build script in the use-upstream branch.
The main change is that we leverage the zig package manager to fetch the sqlite amalgamation instead of vendoring the source code in this repository.

I'm looking for people that can test their programs with this branch and report back if everything works fine; for people not using the loadable extension feature everything should be transparent.

If you are using loadable extensions however, there is a breaking change: you need to use the sqliteext module in your build script instead of sqlite.
To summarize:

  • loadable extensions => sqliteext
  • everything else => sqlite

I'll wait a couple of weeks before merging the branch.

@lun-4
Copy link
Contributor

lun-4 commented Jan 24, 2025

is there any way this could be backported to the zig-0.13.0 branch? I pin my projects to stable zig versions nowadays

@vrischmann
Copy link
Owner Author

is there any way this could be backported to the zig-0.13.0 branch? I pin my projects to stable zig versions nowadays

It's probably doable, but I didn't really want to introduce a stable branch until zig 0.14.0, and given zig 0.14.0 is intended to be released soon-ish, I don't think I want to do this work.

However if anyone wants to work on this I'll happily review a PR.

@malcolmstill
Copy link
Contributor

This looks to work fine for me with malcolmstill/clerk#43, just had to remove a exe.linkLibrary(sqlite.artifact("sqlite")); line from my build.zig.

@vrischmann
Copy link
Owner Author

This looks to work fine for me with malcolmstill/clerk#43, just had to remove a exe.linkLibrary(sqlite.artifact("sqlite")); line from my build.zig.

Nice, thank you for testing !

@vrischmann
Copy link
Owner Author

I'm kind of surprised that the artifact doesn't exist anymore, not sure exactly what causes it to be available in the first place so I'll look into it.

@vrischmann
Copy link
Owner Author

vrischmann commented Jan 28, 2025

Nevermind, I found the issue, I removed the call to installArtifact for the library and forgot to add it back.

(but yeah, the linkLibrary call is not necessary, addImport is enough).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants