fix: address transition type incompatibility with Vue 2.7.16 (#3882)

vuejs · Feb 29, 2024 · 89c38ef · 89c38ef
1 parent 09c0480
commit 89c38ef
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 8 deletions.
diff --git a/packages/language-core/src/generators/template.ts b/packages/language-core/src/generators/template.ts
@@ -1365,6 +1365,15 @@ export function generate(
 					continue;
 				}
 
+				if (
+					vueCompilerOptions.target < 3
+					&& (node.tag === 'transition' || node.tag === 'Transition')
+					&& prop.name === 'persisted'
+				) {
+					// Vue 2 Transition doesn't support "persisted" property but `@vue/compiler-dom always adds it (#3881)
+					continue;
+				}
+
 				let camelized = false;
 
 				if (

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test-workspace/package.json b/test-workspace/package.json
@@ -4,6 +4,6 @@
 	"devDependencies": {
 		"vue": "^3.3.0",
 		"vue-component-type-helpers": "1.8.27",
-		"vue2": "npm:[email protected]"
+		"vue2": "npm:[email protected].16"
 	}
 }
diff --git a/test-workspace/tsc/vue2_strictTemplate/#3881/main.vue b/test-workspace/tsc/vue2_strictTemplate/#3881/main.vue
@@ -0,0 +1,10 @@
+<template>
+  <div>
+    <transition>
+      <span v-show="true">foo</span>
+    </transition>
+    <Transition>
+      <span v-show="true">foo</span>
+    </Transition>
+  </div>
+</template>
diff --git a/test-workspace/tsc/vue2_strictTemplate/tsconfig.json b/test-workspace/tsc/vue2_strictTemplate/tsconfig.json
@@ -4,6 +4,7 @@
 		"target": 2.7,
 	},
 	"include": [
+		"**/*",
 		"../vue2/env.d.ts",
 		"../vue3_strictTemplate",
 	],