Skip to content

Commit

Permalink
fix: exclude vue directive syntax injection in Angular bindings (#3891)
Browse files Browse the repository at this point in the history
Vue directive syntax captures take over required terminating characters
for expressions inside Angular template bindings. These bindings are
identifiable with `meta.ng-binding` (https://github.com/angular/vscode-ng-language-service/blob/5d73b53115db57ea868f11aa5caa4bc0d890bb12/syntaxes/template-tag.json#L43).

angular/vscode-ng-language-service#1989
angular/vscode-ng-language-service#2005
  • Loading branch information
atscott authored Feb 29, 2024
1 parent 1ebbb71 commit d5ab9ed
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions extensions/vscode/syntaxes/vue-directives.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"$schema": "https://raw.githubusercontent.com/martinring/tmlanguage/master/tmlanguage.json",
"fileTypes": [],
"injectionSelector": "L:meta.tag -meta.attribute -entity.name.tag.pug -attribute_value -source.tsx -source.js.jsx, L:meta.element -meta.attribute",
"injectionSelector": "L:meta.tag -meta.attribute -meta.ng-binding -entity.name.tag.pug -attribute_value -source.tsx -source.js.jsx, L:meta.element -meta.attribute",
"patterns": [
{
"include": "source.vue#vue-directives"
}
],
"scopeName": "vue.directives"
}
}

0 comments on commit d5ab9ed

Please sign in to comment.