Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): special treatment for number elements inside v-for #3859

Merged
merged 5 commits into from
Mar 20, 2024
Merged

fix(language-core): special treatment for number elements inside v-for #3859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30fe8f4
tests
so1ve Jan 18, 2024
3bd4018
fix
so1ve Jan 18, 2024
4f64ebe
Merge branch 'master' into pr/3859
johnsoncodehk Jan 20, 2024
32c112e
Merge branch 'master' into pr/3859
johnsoncodehk Mar 20, 2024
da4b8bd
Update script.ts
johnsoncodehk Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions packages/language-core/lib/generators/script.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,19 +211,25 @@ const __VLS_intrinsicElements: __VLS_IntrinsicElements;
function __VLS_getVForSourceType(source: number): [number, number, number][];
function __VLS_getVForSourceType(source: string): [string, number, number][];
function __VLS_getVForSourceType<T extends any[]>(source: T): [
T[number], // item
number, // key
number, // index
item: T[number],
key: number,
index: number,
][];
function __VLS_getVForSourceType<T extends { [Symbol.iterator](): Iterator<any> }>(source: T): [
T extends { [Symbol.iterator](): Iterator<infer T1> } ? T1 : never, // item
number, // key
undefined, // index
item: T extends { [Symbol.iterator](): Iterator<infer T1> } ? T1 : never,
key: number,
index: undefined,
][];
// #3845
function __VLS_getVForSourceType<T extends number | { [Symbol.iterator](): Iterator<any> }>(source: T): [
item: number | (Exclude<T, number> extends { [Symbol.iterator](): Iterator<infer T1> } ? T1 : never),
key: number,
index: undefined,
][];
function __VLS_getVForSourceType<T>(source: T): [
T[keyof T], // item
keyof T, // key
number, // index
item: T[keyof T],
key: keyof T,
index: number,
][];

// @ts-ignore
Expand Down
17 changes: 17 additions & 0 deletions test-workspace/tsc/vue3/#3845/main.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<script setup lang="ts">
import { exactType } from '../../shared';
declare const list1: number | number[];
declare const list2: string | number[];
declare const list3: string | number;
declare const list4: string | number | { [Symbol.iterator](): Iterator<any> };
declare const list5: string | number | Set<string>;
</script>

<template>
<div v-for="f in list1" :key="f">{{ exactType(f, 1 as number) }}</div>
<div v-for="f in list2" :key="f">{{ exactType(f, 1 as string | number) }}</div>
<div v-for="f in list3" :key="f">{{ exactType(f, 1 as string | number) }}</div>
<div v-for="f in list4" :key="f">{{ exactType(f, 1 as any) }}</div>
<div v-for="f in list5" :key="f">{{ exactType(f, 1 as string | number | string) }}</div>
</template>
Loading