Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case-insensitive on isActive property #3656

Open
Kyle-Ye opened this issue Oct 28, 2021 · 4 comments
Open

case-insensitive on isActive property #3656

Kyle-Ye opened this issue Oct 28, 2021 · 4 comments
Labels
bug fixed on 4.x This issue has been already fixed on the v4 but exists in v3

Comments

@Kyle-Ye
Copy link

Kyle-Ye commented Oct 28, 2021

Version

3.5.3

Reproduction link

localhost/active-links/abouT

Steps to reproduce

What is expected?

The "/about" will be treated as active.

What is actually happening?

The "/about" is not treated as active.


Since Vue Router already supports case-insensitive matching for routes themselves. I think it should be the same for the active match to be case-insensitive too.

@posva
Copy link
Member

posva commented Oct 28, 2021

Provide a valid repro please

@Kyle-Ye
Copy link
Author

Kyle-Ye commented Oct 28, 2021

I think using a website like CodePen to build a minimal reproducible environment seems to be low-benifit and troublesome because we can directly use the existing example files(repo's /examples/activeLinks folder and so on) of the repo to reproduce. Just run yarn run dev(or node examples/server.js) and go to http://localhost:8080/active-links/abouT will reproduce the issue

@posva posva added bug fixed on 4.x This issue has been already fixed on the v4 but exists in v3 and removed need repro labels Oct 28, 2021
@posva
Copy link
Member

posva commented Oct 28, 2021

Aah, I couldn't guess you were talking about the repository examples!

@Kyle-Ye
Copy link
Author

Kyle-Ye commented Oct 28, 2021

Aah, I couldn't guess you were talking about the repository examples!

Sorry that I didn't make it clear😂

Kyle-Ye added a commit to Kyle-Ye/vue-router that referenced this issue Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed on 4.x This issue has been already fixed on the v4 but exists in v3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants