Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: cbreaker supports configuring a minimum number of requests #241

Open
hanxiantao opened this issue Jul 24, 2024 · 1 comment

Comments

@hanxiantao
Copy link

While using Traefik, we noticed that the circuitbreaker functionality within middlewares appears to be implemented using cbreaker. However, currently, cbreaker does not support configuring a minimum number of requests to determine when to trip the circuit, a feature that is available in frameworks like Hystrix.
In Hystrix, there is a configuration parameter called requestVolumeThreshold (defaulted to 20), which dictates that only when this threshold is met or exceeded within a sliding time window, will Hystrix start calculating the failure rate and decide whether to open the circuit breaker based on this rate. Even if all requests fail within the sliding window, the circuit breaker will not open if the number of requests falls below this threshold.
We would like to inquire if there are any plans to add similar functionality to cbreaker, allowing us to configure a minimum number of requests before circuit breaker decisions are made. This would prevent unnecessary circuit trips due to low request volumes and help maintain service stability under varying load conditions.

@hanxiantao
Copy link
Author

If you find this proposal reasonable, I would be willing to assist in implementing this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant