Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing PPO + Transformer-XL #442

Open
MarcoMeter opened this issue Jan 4, 2024 · 3 comments
Open

Contributing PPO + Transformer-XL #442

MarcoMeter opened this issue Jan 4, 2024 · 3 comments

Comments

@MarcoMeter
Copy link
Collaborator

MarcoMeter commented Jan 4, 2024

Hey @vwxyzjn
it's been quite a few extremely busy months, but now, I finally have the capacity to contribute a single file implementation of PPO with Transformer-XL as episodic memory. The implementation would be based on my repo. Concerning benchmark, I would like to use Memory Gym (Code, Paper).

If you are interested, I'll get started soon.

@vwxyzjn
Copy link
Owner

vwxyzjn commented Jan 9, 2024

Hey @MarcoMeter, this is pretty cool! Sorry it took me a while to get back to you. Do you want to make it a bit more self-contained, like creating a cleanrl/ppo_trxl/ppo_trxl.py? You can create the dependencies in cleanrl/ppo_trxl/pyproject.toml cleanrl/ppo_trxl/poetry.lock.

The main thing we are looking for a succinct, understandable implementations, benchmarks, and docs(see how we documented https://docs.cleanrl.dev/rl-algorithms/dqn/#dqn_ataripy as an example).

@MarcoMeter
Copy link
Collaborator Author

Work is still in progress, so stay tuned ;)
https://github.com/MarcoMeter/episodic-transformer-memory-ppo/blob/cleanrl/train.py
I'll open a PR once ready.

@MarcoMeter
Copy link
Collaborator Author

@vwxyzjn
I finally resolved the issue. Only one linear layer was supposed to be between the CNN and the transformer blocks. Quiet surprising that this additional layer hampered performance a lot.

@vwxyzjn vwxyzjn reopened this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants