Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-actions example: is "Actions for" redundant in aria-label="Actions for Nurse shark tab" #3192

Open
aleventhal opened this issue Dec 12, 2024 · 1 comment
Labels
Example Page Related to a page containing an example implementation of a pattern question Issue asking a question

Comments

@aleventhal
Copy link

aleventhal commented Dec 12, 2024

Since authors will be following this, I was wondering if we really want authors to be putting "Actions for" or something with the word "Actions" in the actual action labels. We (Chromium) are using this example with screen reader vendors, and I'm concerned that they'll not mention that it's an action since it will sound redundant with the label.

Honestly, I think every word in the label is redundant, such as "Nurse shark" being redundant with the current focus and redundant as well as "tab" also being redundant with the role.

Not sure what a good label would be or what guidance we want to give authors on labelling actions.

Related example:
https://www.w3.org/WAI/ARIA/apg/patterns/tabs/examples/tabs-actions/

@mcking65
Copy link
Contributor

Aaron, I don't understand your point.

The fact that the menubutton is referenced by aria-actions does not change naming requirements. If you remove aria-actions from the example, everything still has to work correctly. The menubutton opens an action menu for the related tab. So, it's name must convey that.

If focus is on one of the tabs and the screen reader is telling me about the available actions, in this case, there is just one action, which is to open the actions menu for that tab. Arguably, the example might be more interesting if focusing the tab instead revealed four action buttons, one for each of the actions that is currently inside of the menu. However, we didn't do that because that doesn't seem to be how context actions are typically designed for tabs.

This example is intended to be super basic. We can certainly make some more interesting ones.

BTW, when it comes to this specific example, I don't think there is a huge advantage to aria-actions for screen reader users. One could argue that the primary benefit is that the common way of rendering context actions for tabs is now allowed by the aria-actions spec. The example works just fine without aria-actions; it just wouldn't be permitted to put the menubuttons in the tablist without the aria-actions reference.

@mcking65 mcking65 added question Issue asking a question Example Page Related to a page containing an example implementation of a pattern labels Jan 14, 2025
@mcking65 mcking65 moved this from Next Steps to In Progress in Tabs Pattern and Examples Development Project Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Example Page Related to a page containing an example implementation of a pattern question Issue asking a question
Development

No branches or pull requests

3 participants
@aleventhal @mcking65 and others