-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-color] Accessibility of Figures in §4.4 and §5 #7691
Comments
Thanks for these helpful comments. I wonder whether adding row and column numbers/letters (to both the image, and also as headers to the table) would help? So someone could talk about row C, column 4 for example? A linear list of 24 numbers, as a screen reader presentation, doesn't seem all that helpful. |
(Sigh, I keep labelling commits with the wrong issue number, there are two very similar. sorry!) |
Yes, I agree; the headers you've added are helpful. Part of accessibility is helping to give people an equivalent frame of reference, so they can collaborate—so this sort of coordination (literally) is spot-on. In theory you shouldn't need the |
Given that, I will apply the same fix to the other figure. |
@matatk is this issue now resolved to your satisfaction in the Editor's Draft? |
@svgeesus your changes are great; thanks. I haven't closed this issue with this comment though, because when I visit figure 5 in the Editor's Draft the changes to the images don't show up for me (have tried hard-refreshing). |
That sounds like a local cache issue to me. Could I suggest directly viewing https://drafts.csswg.org/css-color-5/images/macbeth-roundtrip.svg and then doing a hard refresh on that? |
@matatk are you seeing the updated figure, now? |
@matatk please confirm? |
Sorry for the delay. The Editor's Draft is currently inaccessible, but when I follow the link you gave to the files directly ("macbeth-*.svg") I can see the changes are there; thank you! Feel free to close. |
Apologies. Meanwhile please use https://w3c.github.io/csswg-drafts/css-color-5/ until the down-every-day official csswg drafts server is fixed. |
This comment is from the APA WG and relates to our review of CSS Color Module Level 5.
§4.4 Figure 5
<img>
needsalt
text such as "A color swatch, in a grid layout".<table>
but doesn't seem to be one semantically (it's just placing the text to match the layout of the color swatch above). Suggest applyingrole="presentation"
to the table, to remove the tabular structure semantics (or you could re-code it using<div>
s and<span>
s). That would have the effect of linearizing the table from a screen reader perspective, but that would likely be less confusing than encountering a "table" without headers.§5 Figure 6 [doesn't have an
id
]<img>
needs analt
attribute that explains this is a color swatch in a grid formation (as per figure 5) but that circles are imposed on each grid square. The<figcaption>
does a great job of explaining the rest.<div>
s and<span>
s).The text was updated successfully, but these errors were encountered: