Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-color] Accessibility of Figures in §4.4 and §5 #7691

Closed
matatk opened this issue Sep 4, 2022 · 11 comments
Closed

[css-color] Accessibility of Figures in §4.4 and §5 #7691

matatk opened this issue Sep 4, 2022 · 11 comments
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-color-5 Color modification

Comments

@matatk
Copy link

matatk commented Sep 4, 2022

This comment is from the APA WG and relates to our review of CSS Color Module Level 5.

§4.4 Figure 5

  • The <img> needs alt text such as "A color swatch, in a grid layout".
  • The second part is marked up as a <table> but doesn't seem to be one semantically (it's just placing the text to match the layout of the color swatch above). Suggest applying role="presentation" to the table, to remove the tabular structure semantics (or you could re-code it using <div>s and <span>s). That would have the effect of linearizing the table from a screen reader perspective, but that would likely be less confusing than encountering a "table" without headers.

§5 Figure 6 [doesn't have an id]

  • The <img> needs an alt attribute that explains this is a color swatch in a grid formation (as per figure 5) but that circles are imposed on each grid square. The <figcaption> does a great job of explaining the rest.
  • As with figure 5, this table should have the table semantics removed (or be re-coded using <div>s and <span>s).
@matatk matatk changed the title [css-color] Accessibility of Figures and Examples in §4.4 and §5 [css-color] Accessibility of Figures in §4.4 and §5 Sep 4, 2022
@svgeesus
Copy link
Contributor

svgeesus commented Sep 4, 2022

Thanks for these helpful comments.

I wonder whether adding row and column numbers/letters (to both the image, and also as headers to the table) would help? So someone could talk about row C, column 4 for example?

A linear list of 24 numbers, as a screen reader presentation, doesn't seem all that helpful.

@svgeesus
Copy link
Contributor

svgeesus commented Sep 5, 2022

(Sigh, I keep labelling commits with the wrong issue number, there are two very similar. sorry!)

@matatk
Copy link
Author

matatk commented Sep 5, 2022

Yes, I agree; the headers you've added are helpful. Part of accessibility is helping to give people an equivalent frame of reference, so they can collaborate—so this sort of coordination (literally) is spot-on.

In theory you shouldn't need the scope attribute on the table header cells, and I just tested in the latest Firefox and Chrome, with NVDA and JAWS, and there was no problem with them interpreting which were column and row headers, so the markup you have is fine.

@svgeesus
Copy link
Contributor

svgeesus commented Sep 6, 2022

Given that, I will apply the same fix to the other figure.

svgeesus added a commit that referenced this issue Sep 6, 2022
@svgeesus
Copy link
Contributor

svgeesus commented Sep 8, 2022

@matatk is this issue now resolved to your satisfaction in the Editor's Draft?

@matatk
Copy link
Author

matatk commented Sep 8, 2022

@svgeesus your changes are great; thanks. I haven't closed this issue with this comment though, because when I visit figure 5 in the Editor's Draft the changes to the images don't show up for me (have tried hard-refreshing).

@svgeesus
Copy link
Contributor

svgeesus commented Sep 9, 2022

That sounds like a local cache issue to me. Could I suggest directly viewing

https://drafts.csswg.org/css-color-5/images/macbeth-roundtrip.svg

and then doing a hard refresh on that?

@svgeesus
Copy link
Contributor

@matatk are you seeing the updated figure, now?

@svgeesus
Copy link
Contributor

svgeesus commented Oct 5, 2022

@matatk please confirm?

@matatk
Copy link
Author

matatk commented Oct 5, 2022

Sorry for the delay. The Editor's Draft is currently inaccessible, but when I follow the link you gave to the files directly ("macbeth-*.svg") I can see the changes are there; thank you! Feel free to close.

@svgeesus
Copy link
Contributor

svgeesus commented Oct 5, 2022

Apologies. Meanwhile please use https://w3c.github.io/csswg-drafts/css-color-5/ until the down-every-day official csswg drafts server is fixed.

@svgeesus svgeesus closed this as completed Oct 5, 2022
@svgeesus svgeesus added Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-color-5 Color modification
Projects
None yet
Development

No branches or pull requests

2 participants