Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's use github discussions #136

Closed
VladimirAlexiev opened this issue Feb 2, 2021 · 7 comments
Closed

let's use github discussions #136

VladimirAlexiev opened this issue Feb 2, 2021 · 7 comments

Comments

@VladimirAlexiev
Copy link
Contributor

Has anyone used the new "github discussions"?

unitsofmeasurement/uom-systems#182 says that it would be very beneficial for issues like #129 and gives as example unitsofmeasurement/unit-api#225. That one is very short so I can't see the benefit...

But most of the issues here are very long (and fruitful!) discussions, and Github is one of the best (and non-intrusive) UI experiences out there, so I believe that if they made a new feature "discussions", we should try it out.

@VladimirAlexiev
Copy link
Contributor Author

Strike 1: FHIR/Ucum-java#19 links to unitsofmeasurement/unit-api#225 but that discussion doesn't show a back-link.

@JervenBolleman
Copy link
Collaborator

I think enabling this feature doesn't hurt and might help. So I just went and did it. If "dicussions" don't work then we can always turn it off.

@afs
Copy link
Collaborator

afs commented Feb 3, 2021

@VladimirAlexiev - how do you see the difference?

Don't we use issues as discussions; we end up with two mechanisms!

@TallTed
Copy link
Member

TallTed commented Feb 3, 2021

I cannot quickly locate a link to a page telling me about this new github feature... which I'm sure is a failure on my part. But this suggests that such a link should be provided in this #136 and #137 (which appears at first glance not to be very different from an issue, and not only because discussions apparently share sequence numbering with issues and PRs)...

(There are plenty of examples of useless if not problematic features coming from a certain company with a lot of influence over github, so I'm not sure we can rely on a rubric of "they implemented it, it must be a good thing!")

@VladimirAlexiev
Copy link
Contributor Author

@afs yes, we use issues as discussions, and complex issues like #129 become a tangle of many threads.

Ok, I experimented in #137. It has some threading but is not quote so easy to use.

Strike 2: wastes vertical space by allocating a blank emoji on every comment.

@VladimirAlexiev
Copy link
Contributor Author

I think enabling this feature doesn't hurt and might help.

Thanks! The major difference is that in a normal issue like this one, my reply doesn't thread under what I quoted.

@TallTed
Copy link
Member

TallTed commented Feb 4, 2021

Thanks! The major difference is that in a normal issue like this one, my reply doesn't thread under what I quoted.

But every new reply now threads under the first reply to a (topic?), whether it's a direct response to the original post or otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants