Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"algo" function needs refactoring #4

Open
jkahanec opened this issue Aug 10, 2020 · 1 comment
Open

"algo" function needs refactoring #4

jkahanec opened this issue Aug 10, 2020 · 1 comment

Comments

@jkahanec
Copy link
Collaborator

https://github.com/aleem-ahmed/eccentric-trader/blob/0691dce6c969561bb316a21b45a4296e3b030437/client/Algo.js#L13

This function does too much, it needs to be split up. Try to stick to the paradigm that every function should have one job. It will make your code more re-usable, testable, and readable.

Also, 'algo' is a poor name for the function and doesn't really tell me anything. It's a loaded term and not a good choice for a function name. Following the advice above, this problem will most likely work itself out as long as you put in a little effort to name properly.

@aleem-ahmed
Copy link
Collaborator

i was thinking about this earlier today. i will work on it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants