Update blocks in RecipeStreamBlock to use ImageBlock
#526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stormheg
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Looks great from my testing - thanks for picking this up @laymonage ❤️
Couple of minor points, after which I consider this LGTM
| "pk": 54, | ||
| "fields": { | ||
| "collection": 5, | ||
| "title": "Hot_cross_buns_(stacked)", |
There was a problem hiding this comment.
Bakerydemo image library is so tidy, every image has a pretty title.
(not very representative of the real word though - if the sites I work on quality as 'real world' 😄 )
Suggested change
| "title": "Hot_cross_buns_(stacked)", | |
| "title": "Hot cross buns (stacked)", |
There was a problem hiding this comment.
Also, where did you source this image from?
| @@ -0,0 +1,146 @@ | |||
| # Generated by Django 6.0.dev20250116121251 on 2025-02-11 16:44 | |||
To avoid confusion with Wagtail's new built-in ImageBlock
thibaudcolas
approved these changes
Feb 21, 2025
| "pk": 54, | ||
| "fields": { | ||
| "collection": 5, | ||
| "title": "Hot_cross_buns_(stacked)", |
| ./manage.py dumpdata --natural-foreign --indent 2 -e auth.permission -e contenttypes -e wagtailcore.GroupCollectionPermission -e wagtailimages.rendition -e sessions -e wagtailsearch.indexentry -e wagtailsearch.sqliteftsindexentry -e wagtailcore.referenceindex -e wagtailcore.pagesubscription > bakerydemo/base/fixtures/bakerydemo.json | ||
| prettier --write bakerydemo/base/fixtures/bakerydemo.json | ||
| ./manage.py dumpdata --natural-foreign --indent 2 -e auth.permission -e contenttypes -e wagtailcore.GroupCollectionPermission -e wagtailimages.rendition -e sessions -e wagtailsearch.indexentry -e wagtailsearch.sqliteftsindexentry -e wagtailcore.referenceindex -e wagtailcore.pagesubscription -e wagtailcore.workflowcontenttype -e wagtailadmin.editingsession > bakerydemo/base/fixtures/bakerydemo.json | ||
| npx prettier --write bakerydemo/base/fixtures/bakerydemo.json |
thibaudcolas
force-pushed
the
use-image-block-in-recipes
branch
from
2579782 to
e978840
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #492. I opted to leave the existing
BaseStreamBlock.image_blockas-is (aside from renamingImageBlocktoCaptionedImageBlock). Then, I migrated the blocks inRecipeStreamBlockto use Wagtail'sImageBlock. Finally, I added an image block to the Hot Cross Buns page to verify that it works.Unfortunately, this means we don't get to use Wagtail's
ImageBlockin as many places as possible. I laid out the options in #492 (comment), if you'd like a different approach please let me know!