From b65db54aca39212a9e8433d2321140d91fa7e4ee Mon Sep 17 00:00:00 2001 From: Karl Hobley Date: Thu, 9 Jan 2020 16:23:58 +0000 Subject: [PATCH] Add missing .specific --- wagtail_localize/translation/models.py | 8 ++++---- .../translation/tests/test_translatablerevision.py | 4 ++++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/wagtail_localize/translation/models.py b/wagtail_localize/translation/models.py index 22bcc107..b37f31d0 100644 --- a/wagtail_localize/translation/models.py +++ b/wagtail_localize/translation/models.py @@ -102,15 +102,15 @@ class TranslatableRevision(models.Model): @classmethod def get_or_create_from_page_revision(cls, page_revision): - object, created = TranslatableObject.objects.get_or_create_from_instance( - page_revision.page - ) + page = page_revision.page.specific + + object, created = TranslatableObject.objects.get_or_create_from_instance(page) return TranslatableRevision.objects.get_or_create( object=object, page_revision=page_revision, defaults={ - "locale_id": page_revision.page.locale_id, + "locale_id": page.locale_id, "content_json": page_revision.content_json, "created_at": page_revision.created_at, }, diff --git a/wagtail_localize/translation/tests/test_translatablerevision.py b/wagtail_localize/translation/tests/test_translatablerevision.py index 1fadd52b..abaa4575 100644 --- a/wagtail_localize/translation/tests/test_translatablerevision.py +++ b/wagtail_localize/translation/tests/test_translatablerevision.py @@ -60,6 +60,10 @@ def test_create(self): TranslatableRevision.objects.all().delete() page_revision = self.page.get_latest_revision() + + # Refetch the page revision so that it has the generic Page object associated + page_revision.refresh_from_db() + revision, created = TranslatableRevision.get_or_create_from_page_revision( page_revision )