Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overflow support? #30

Open
jitaogithub opened this issue Jul 25, 2020 · 0 comments
Open

Overflow support? #30

jitaogithub opened this issue Jul 25, 2020 · 0 comments

Comments

@jitaogithub
Copy link

Hi there,

It seems from my reading of the code that this implementation doesn't support overflow. That is, say if a timeout of TIMEOUT_MAX + 1 is added before all the timeouts are expired, it will be added to wheel[0][0]. When the time is updated, instead of waiting till next round, this newly added timeout will be expired.

Please correct me if I got anything wrong, or if there is any specific reason why overflow support wasn't added. If not then I'm interested in adding it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jitaogithub