Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent changing JVM System proxy #232

Open
LukasWestholt opened this issue Aug 23, 2022 · 3 comments
Open

Prevent changing JVM System proxy #232

LukasWestholt opened this issue Aug 23, 2022 · 3 comments

Comments

@LukasWestholt
Copy link

Hello everyone!

I have the same problems like #182, but I can't reopen it. I am using the newest version.
In my opinion teardownProxy(); is not a solution. If it fails one time, you have set https.proxyHost forever.

There must be a more reasonable way to use requests with proxy in Java (also for plugin programming). I ask you to reconsider this.

@alanhamlett
Copy link
Member

Yea, I also would like to avoid changing https.proxyHost if possible. I'll look for another way to do https requests that doesn't need changing the system proxy.

@LukasWestholt
Copy link
Author

Thank you!

@alanhamlett alanhamlett changed the title Proxy ... again. Prevent changing JVM System proxy Sep 9, 2022
@alanhamlett
Copy link
Member

alanhamlett commented Sep 9, 2022

Release v14.1.1 should improve this, since I found we didn't correctly reset the system proxy if one wasn't previously set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants