From a1d98b915ef3b1c2039b2b97855c1ecd9547a882 Mon Sep 17 00:00:00 2001 From: Alan Hamlett Date: Wed, 9 Oct 2024 00:05:18 +0200 Subject: [PATCH] Support nested heartbeat response status in 2xx range --- pkg/api/heartbeat.go | 2 +- pkg/offline/offline.go | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/api/heartbeat.go b/pkg/api/heartbeat.go index 4d78e916..2f867f2f 100644 --- a/pkg/api/heartbeat.go +++ b/pkg/api/heartbeat.go @@ -135,7 +135,7 @@ func parseHeartbeatResponse(data []json.RawMessage) (heartbeat.Result, error) { return heartbeat.Result{}, fmt.Errorf("failed to parse json status: %s", err) } - if result.Status >= http.StatusBadRequest { + if result.Status < 200 || result.Status > 299 { resultErrors, err := parseHeartbeatResponseError(data[0]) if err != nil { return heartbeat.Result{}, fmt.Errorf("failed to parse result errors: %s", err) diff --git a/pkg/offline/offline.go b/pkg/offline/offline.go index 8687a83f..12ba0705 100644 --- a/pkg/offline/offline.go +++ b/pkg/offline/offline.go @@ -218,8 +218,7 @@ func handleResults(filepath string, results []heartbeat.Result, hh []heartbeat.H continue } - if result.Status != http.StatusCreated && - result.Status != http.StatusAccepted { + if result.Status < 200 || result.Status > 299 { withInvalidStatus = append(withInvalidStatus, hh[n]) } }