Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track package size to provide valuable insight to developer #46

Open
fryorcraken opened this issue Jan 23, 2023 · 4 comments
Open

Track package size to provide valuable insight to developer #46

fryorcraken opened this issue Jan 23, 2023 · 4 comments
Labels
good first issue Good for newcomers track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications

Comments

@fryorcraken
Copy link
Contributor

See ai/size-limit#299 (comment)
@fryorcraken fryorcraken added the good first issue Good for newcomers label Jan 23, 2023
@weboko
Copy link
Contributor

weboko commented Apr 13, 2023

Applicable to js-waku as well.

@fryorcraken
Copy link
Contributor Author

Applicable to js-waku as well.

We tracked in js-waku PRs. Already, what more are you thinking of?

@weboko
Copy link
Contributor

weboko commented Apr 26, 2023 •
edited
Loading

I would add point to revisit how and what exactly we track in js-waku (I see core is tracked)
Another improvement I would introduce is this, so that we will have a job failed at the over-the-budget change. This brings us into discussion what is an ideal size we'd like to have - additional research should be done.

@fryorcraken
Copy link
Contributor Author

I would add point to revisit how and what exactly we track in js-waku (I see core is tracked) Another improvement I would introduce is this, so that we will have a job failed at the over-the-budget change. This brings us into discussion what is an ideal size we'd like to have - additional research should be done.

Happy to track to revisit. size-limit does provide a similar feature, it's just not used.

@fryorcraken fryorcraken added the track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
Waku
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fryorcraken @weboko