Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor tests for new nodes in fleet #1508

Open
Tracked by #1455
danisharora099 opened this issue Aug 28, 2023 · 1 comment
Open
Tracked by #1455

refactor tests for new nodes in fleet #1508

danisharora099 opened this issue Aug 28, 2023 · 1 comment
Labels
test Issue related to the test suite with no expected consequence to production code

Comments

@danisharora099
Copy link
Collaborator

This is a change request

Problem

The wakuv2.test fleet seems to now have new nodes which leads to our current tests failing: https://github.com/waku-org/js-waku/actions/runs/5996826077/job/16262051110

Proposed Solutions

Refactor expectations in the tests
@weboko weboko added the test Issue related to the test suite with no expected consequence to production code label Aug 31, 2023
@weboko
Copy link
Collaborator

weboko commented Aug 31, 2023

Check if we count nodes without duplicates.

@weboko weboko mentioned this issue Sep 14, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issue related to the test suite with no expected consequence to production code
Projects
Waku
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danisharora099 @weboko