Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Filter and Relay should be compliant with IReceiver #1713

Open
4 tasks
danisharora099 opened this issue Nov 8, 2023 · 1 comment
Open
4 tasks

chore: Filter and Relay should be compliant with IReceiver #1713

danisharora099 opened this issue Nov 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@danisharora099
Copy link
Collaborator

With work on #1682, we are changing the Filter API -- this also impacts the IRelay API as both of these protocol implementations are expected to be compliant with our IReceiver interface.

In the interest of keeping the PR straightforward, only Filter refactor is addressed with #1682.

This issue aims to track the work around Relay, and necessary updates to the IReceiver API.

This was discussed in the PM meeting (#1683 (comment)).

Acceptance Criteria:

  • update Relay protocol, in a similar structure as Filter
  • emsure Filter and Relay are compliance with IReceiver (update IReceiver accordingly)
  • update & ensure these protocol implementations work with toAsyncIterator
    • un-skip the Util: toAsyncIterator: Filter test
@chair28980
Copy link
Contributor

Depends on #1683

@chair28980 chair28980 added the enhancement New feature or request label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Icebox
Development

No branches or pull requests

2 participants