Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report an error when js-waku is running over http and hence cannot connect via WSS #1991

Open
vpavlin opened this issue Apr 29, 2024 · 1 comment

Comments

@vpavlin
Copy link
Member

vpavlin commented Apr 29, 2024

This is a change request

Problem

When a js-waku app is ran on HTTP (not HTTPS) and also not localhost connection-manager will silently fail to connect to any node.

This is visible when debug:waku* is enabled, but not in "production" setting

waku:error:connection-manager Error dialing peer 16Uiu2HAmSve7tR5YZugpskMv2dmJAsMUKmfWYEKRXNUxRaTCnsXV - Error occurred during XX handshake: Error occurred while verifying signed payload: TypeError: Cannot read properties of undefined (reading 'digest') +0ms

Proposed Solutions

Surface an error/warning about not using HTTPS and hence not being able to connect to any peers to the dev/user

Notes

@weboko
Copy link
Collaborator

weboko commented May 2, 2024

Let's confirm that full nodes advertise ws connection and not only wss.

In nwaku-compose - https://github.com/waku-org/nwaku-compose/blob/8abb2a474d9bf9f9acc5c3a8bc03c4eda015551d/run_node.sh#L36

Todo:

  • make sure local development over HTTP works;
  • double check that ws connection can be established if advertised by node;
  • if problem persists with establishing connection from http to ws we should add warning;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do
Development

No branches or pull requests

2 participants