Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: filter sdk does not dial newly added peers #2079

Closed
weboko opened this issue Jul 22, 2024 · 1 comment
Closed

bug: filter sdk does not dial newly added peers #2079

weboko opened this issue Jul 22, 2024 · 1 comment
Assignees
@weboko
Labels
bug Something isn't working enhancement New feature or request

Comments

@weboko
Copy link
Collaborator

weboko commented Jul 22, 2024

This is a bug report

Problem

When maintainPeers happens from the background in BaseProtocol - it does not notify SubscriptionManager to send a subscription request.

Due to this messages are not getting received when subscription was created right on start of an app without reliable peers.

Proposed Solutions

Create a notify mechanism that would trigger subscription request if renew happened in BaseProtocol.

Note

Partially blocks - waku-org/lab.waku.org#68
@weboko weboko added bug Something isn't working enhancement New feature or request labels Jul 22, 2024
@weboko weboko self-assigned this Jul 22, 2024
@weboko weboko mentioned this issue Jul 22, 2024
Merged
@weboko
Copy link
Collaborator Author

weboko commented Aug 22, 2024

Seems not to be happening against waku-org/lab.waku.org#83 with @waku/[email protected]

@weboko weboko closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weboko weboko

Labels
bug Something isn't working enhancement New feature or request
Projects
Waku
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weboko