bug: peer management of subscriptions is questionable

[weboko]

This is a bug report

Problem

Filter subscription's peer management is not ideal so that ping has no peers to use because this.getPeers returns empty array, probably, due to previous renewals.

But at the same time subscription is functioning so that all previously used peers are still returning messages.

Proposed Solutions

This issue requires investigation.

Once renewal has happened - previously used peer should not be used and has to be removed properly.

[weboko]

Figured the bug. This issue happens due to how renewal logic works:

js-waku/packages/sdk/src/reliability_monitor/receiver.ts

Line 172 in b2efce5

private async renewAndSubscribePeer(

During renewal - we add new peer and create a subscription to it without unsubscribing from previous peer AND without disconnecting.
At the same time libp2p still awaits for filter-push here

js-waku/packages/core/src/lib/filter/index.ts

Line 45 in b2efce5

libp2p

And once previously "used" peer pushes messages to js-waku - it successfully receives it.

For now it is not a critical bug for functionality of Filter but it definitely is not expected behavior.

Fix:

• unsubscribe on renewal
• potentially drop connections to renewed peers

Blocked by #2158 and potentially #1969 (as we need to improve connection management before).