bug: reliability monitor renews working peers from Filter or does not renew not working peer

[weboko]

Problem

It happens that when js-waku lands on a working peer and subscribes to it after some time it disconnects from it though it should've been kept.

Another thing that happens is - when a node that is not pushing Filter messages to js-waku is hit it might stay with is for some time. We should address it.

Solution

Refine ReliabilityMonitor not to do it.

Logs

waku:warn:sdk:receiver:reliability_monitor Peer 16Uiu2HAmNaeL4p3WEYzC9mgXBmBWSgWjPHRvatZTXnp8Jgv3iKsb not initialized in receivedMessagesHashes.nodes, adding it. +0ms
common.js:113 waku:warn:sdk:receiver:reliability_monitor Peer 16Uiu2HAkvUSXfavB9tJKr2Ut6abnN82KsxYU1Hb7HZ3ZdPRMjBde not initialized in receivedMessagesHashes.nodes, adding it. +7s
common.js:113 waku:info:sdk:receiver:reliability_monitor Peer 16Uiu2HAmHUg6yWTwQhMu3GnxxaeE1KwKz6QvvwbtyZ2D4LUVgGf3 has missed too many messages, renewing. +0ms
common.js:113 waku:info:sdk:receiver:reliability_monitor Peer 16Uiu2HAmNaeL4p3WEYzC9mgXBmBWSgWjPHRvatZTXnp8Jgv3iKsb has missed too many messages, renewing. +171ms
common.js:113 waku:info:sdk:receiver:reliability_monitor Peer 16Uiu2HAkvUSXfavB9tJKr2Ut6abnN82KsxYU1Hb7HZ3ZdPRMjBde has missed too many messages, renewing. +143ms
common.js:113 waku:error:sdk:receiver:reliability_monitor Unexpected Error: Peer 16Uiu2HAkvUSXfavB9tJKr2Ut6abnN82KsxYU1Hb7HZ3ZdPRMjBde not found in connected peers. +0ms
common.js:113 waku:error:sdk:sender:reliability_monitor Failed to send message after retry to 16Uiu2HAmHUg6yWTwQhMu3GnxxaeE1KwKz6QvvwbtyZ2D4LUVgGf3: [object Object] +0ms
common.js:113 waku:error:sdk:sender:reliability_monitor Failed to send message after retry to 16Uiu2HAmHUg6yWTwQhMu3GnxxaeE1KwKz6QvvwbtyZ2D4LUVgGf3: [object Object] +1ms
common.js:113 waku:info:sdk:sender:reliability_monitor Renewed peer 16Uiu2HAmHUg6yWTwQhMu3GnxxaeE1KwKz6QvvwbtyZ2D4LUVgGf3 to 16Uiu2HAmNaeL4p3WEYzC9mgXBmBWSgWjPHRvatZTXnp8Jgv3iKsb +0ms
common.js:113 waku:info:sdk:receiver:reliability_monitor Peer 16Uiu2HAkvUSXfavB9tJKr2Ut6abnN82KsxYU1Hb7HZ3ZdPRMjBde has missed too many messages, renewing. +9s
common.js:113 waku:error:sdk:receiver:reliability_monitor Unexpected Error: Peer 16Uiu2HAkvUSXfavB9tJKr2Ut6abnN82KsxYU1Hb7HZ3ZdPRMjBde not found in connected peers. +9s
common.js:113 waku:info:sdk:receiver:reliability_monitor Peer 16Uiu2HAkvUSXfavB9tJKr2Ut6abnN82KsxYU1Hb7HZ3ZdPRMjBde has missed too many messages, renewing. +0ms
common.js:113 waku:error:sdk:receiver:reliability_monitor Unexpected Error: Peer 16Uiu2HAkvUSXfavB9tJKr2Ut6abnN82KsxYU1Hb7HZ3ZdPRMjBde not found in connected peers. +0ms
common.js:113 waku:info:sdk:receiver:reliability_monitor Peer 16Uiu2HAmHvpidgNVuAnBbntCq5wPaGw8rMrnV2y1sUKAX3GXG2g7 has missed too many messages, renewing. +0ms
common.js:113 waku:error:sdk:sender:reliability_monitor Failed to send message after retry to 16Uiu2HAmNaeL4p3WEYzC9mgXBmBWSgWjPHRvatZTXnp8Jgv3iKsb: [object Object] +7s
common.js:113 waku:error:sdk:sender:reliability_monitor Failed to send message after retry to 16Uiu2HAmNaeL4p3WEYzC9mgXBmBWSgWjPHRvatZTXnp8Jgv3iKsb: [object Object] +1ms
common.js:113 waku:info:sdk:sender:reliability_monitor Renewed peer 16Uiu2HAmNaeL4p3WEYzC9mgXBmBWSgWjPHRvatZTXnp8Jgv3iKsb to 16Uiu2HAmHvpidgNVuAnBbntCq5wPaGw8rMrnV2y1sUKAX3GXG2g7 +7s
common.js:113 waku:error:sdk:sender:reliability_monitor Failed to send message after retry to 16Uiu2HAmHvpidgNVuAnBbntCq5wPaGw8rMrnV2y1sUKAX3GXG2g7: [object Object] +7s
common.js:113 waku:error:sdk:sender:reliability_monitor Failed to send message after retry to 16Uiu2HAmHvpidgNVuAnBbntCq5wPaGw8rMrnV2y1sUKAX3GXG2g7: [object Object] +1ms
common.js:113 waku:info:sdk:sender:reliability_monitor Renewed peer 16Uiu2HAmHvpidgNVuAnBbntCq5wPaGw8rMrnV2y1sUKAX3GXG2g7 to 16Uiu2HAmDCp8XJ9z1ev18zuv8NHekAsjNyezAvmMfFEJkiharitG

[weboko]

Looking into this now, attempting to improve some of the parts of ReliabilityMonitor.

[weboko]

[weboko]

Blocked by #2139, waiting for code implementation there

[weboko]

This issue should cover this as well - #2137 (comment):

[weboko]

Unblocked as PR is about to be merged #2137 (review)