Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify internal message flow #3000

Open
SionoiS opened this issue Aug 27, 2024 · 5 comments
Open

chore: clarify internal message flow #3000

SionoiS opened this issue Aug 27, 2024 · 5 comments
Labels
effort/days Estimated to be completed in a few days, less than a week enhancement New feature or request

Comments

@SionoiS
Copy link
Contributor

SionoiS commented Aug 27, 2024

I realized that a user expecting a Filter subscribe to return messages from Sync is going to be disappointed...

More generally, do we need a higher level get me all the new messages from wherever API?

If we think about the flow of messages, a Waku node can output msgs to Relay, Filter and Sync. Inputs would be Relay, Light push, Sync. It would make sense that a msg from Sync is not relayed but should it be used by Filter?

🤷

WDYT? @waku-org/nwaku-developers @jm-clius

@SionoiS SionoiS added the enhancement New feature or request label Aug 27, 2024
@jm-clius
Copy link
Contributor

This is a reasonable question, though one that will be more appropriately answered once Sync (and Store) is more integrated into our message propagation protocols. For now, it's simply an augmentation of Store and synced messages will only be accessible via store queries and/or store API

@gabrielmer gabrielmer added the effort/days Estimated to be completed in a few days, less than a week label Aug 29, 2024
@Ivansete-status
Copy link
Collaborator

@SionoiS - Isn't sync only considered to be used from within store nodes? Sorry but I can't quite see the issue now :)

@SionoiS
Copy link
Contributor Author

SionoiS commented Sep 6, 2024

@SionoiS - Isn't sync only considered to be used from within store nodes? Sorry but I can't quite see the issue now :)

True, it's mostly a UX problem and expectation.

@Ivansete-status
Copy link
Collaborator

True, it's mostly a UX problem and expectation.

ah okay , I wonder if it may help allowing sync == true only if store == true

@NagyZoltanPeter
Copy link
Contributor

@SionoiS - Isn't sync only considered to be used from within store nodes? Sorry but I can't quite see the issue now :)

True, it's mostly a UX problem and expectation.

From this point of view, IMHO, it is the missing SDK layer that could hide the "get me all messages I don't care from where" API.
So without that layer we would just introduce more and more complex troubles into the node itself. Without outsourcing such logic we put wishful thinking into clients head (aka "This API will do for me anything I want").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to be completed in a few days, less than a week enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

5 participants