Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make negentropy to give better feedback when failures happen #3007

Open
Tracked by #3071
Ivansete-status opened this issue Aug 30, 2024 · 1 comment
Open
Tracked by #3071
Assignees
Labels
effort/days Estimated to be completed in a few days, less than a week

Comments

@Ivansete-status
Copy link
Collaborator

Description

While dogdoofing waku sync in status.staging @SionoiS noticed that there are many negentropy failures but we don't know the actual reason why that happened.

  • failed to insert message
  • erase failed

The goal of this is to enhance negentropy's feedback in case a wrong condition happens.

For example, we see the following logs but the detail given by negentropy is not verbose enough:

error "failed to insert message ", msg_hash = msgHash.to0xHex(), error = $error

if self.storage.insert(msg.timestamp, msgHash).isErr():

error "storage erase failed",

@SionoiS
Copy link
Contributor

SionoiS commented Aug 30, 2024

AFAIK Inserting twice the same element would return an error, it is expected. Same for trying to erase twice the same element.

The problem is we don't know which error it is. I feel like making insert and erase Idempotent would be best.

@gabrielmer gabrielmer added the effort/days Estimated to be completed in a few days, less than a week label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to be completed in a few days, less than a week
Projects
Status: Priority
Development

No branches or pull requests

4 participants