Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: take off filter message push timeouts from message handling metric #3012

Open
NagyZoltanPeter opened this issue Sep 3, 2024 · 0 comments
Labels
effort/days Estimated to be completed in a few days, less than a week

Comments

@NagyZoltanPeter
Copy link
Contributor

Background

Filter v2 message push timeouts make noise in the waku_filter_handle_message_duration_seconds metric.
It is enough one subscribed peer to disconnect to reach push timeout. So the metric will get +inf bucket filled for the histogram that correlates with the filter errors metric (push timeout).

Details

image

Acceptance criteria

waku_filter_handle_message_duration_seconds should measure message push durations only for the successful push operations. Consider to separate failing peers pushes from the successful ones. Maybe consider measure an average duration between push to peers inside one event.

@Ivansete-status Ivansete-status added the effort/days Estimated to be completed in a few days, less than a week label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to be completed in a few days, less than a week
Projects
Status: To Do
Development

No branches or pull requests

2 participants