Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition updates prompt creating + defining already existing glossary terms #107

Closed
lgeistlinger opened this issue Nov 25, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@lgeistlinger
Copy link
Collaborator

lgeistlinger commented Nov 25, 2021

I edited the experiments of Study 538 and changed the condition from the invalid "urinary track infection" to the valid condition glossary term urinary tract infection.

However, when visiting the updated page the condition field of eg Experiment 1 does not recognize the existing condition glossary term urinary tract infection - as the term is marked in red and mousing over the term prompts me to "create and define glossary term".

It does recognize it to a certain extent though, as the icon links beside the term point to the corresponding EFO page. BTW: I am confused about the icon beside the efo / uberon icon. It seems to point to the exact same pages and thus obsolete?

Screen Shot 2021-11-25 at 1 09 31 PM

@lgeistlinger lgeistlinger added the bug Something isn't working label Nov 25, 2021
@tosfos
Copy link
Collaborator

tosfos commented Nov 29, 2021

This is related to the issue I highlighted at #92 (comment)

It's caused by the wiki finding more than 1 matching Condition. Once we decide out how to deal with that situation, this should be resolved, but we should leave this open to make sure it gets solved.

@lgeistlinger
Copy link
Collaborator Author

Looks like this has been fixed and can be closed.

Remaining question:

BTW: I am confused about the icon beside the efo / uberon icon. It seems to point to the exact same pages and thus obsolete?

Should I open a separate issue for that?

@tosfos
Copy link
Collaborator

tosfos commented Jan 7, 2022

Sorry about the long delay. I agree that we should be able to combine these into one icon. I'll get back to you soon.

@lgeistlinger
Copy link
Collaborator Author

Thanks!

@tosfos
Copy link
Collaborator

tosfos commented Jan 17, 2022

Should be better now:
image

@lgeistlinger
Copy link
Collaborator Author

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants