Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 文档中给出的 React 示例代码有一处小错误 || [Bug]: There is a small error in the React sample code given in the documentation #2161

Closed
YieldRay opened this issue Nov 27, 2023 · 0 comments
Labels
bug Something isn't working contribution welcome Contribution about current issue is welcomed

Comments

@YieldRay
Copy link
Contributor

YieldRay commented Nov 27, 2023

问题描述 | Describe the bug

https://waline.js.org/cookbook/import/project.html#%E5%9C%A8-react-%E9%A1%B9%E7%9B%AE%E4%B8%AD%E5%AF%BC%E5%85%A5 给出的代码的 27 行应该为

  useEffect(() => {
    walineInstanceRef.current?.update(props);
  }, [props]); // dependencies 参数是数组

问题网站 | Website URL

https://waline.js.org/cookbook/import/project.html#%E5%9C%A8-react-%E9%A1%B9%E7%9B%AE%E4%B8%AD%E5%AF%BC%E5%85%A5


Problem description | Describe the bug

at <https://waline.js.org/cookbook/import/project.html#%E5%9C%A8-react-%E9%A1%B9%E7%9B%AE%E4%B8%AD%E5% AF%BC%E5%85%A5> Line 27 of the given code should be

  useEffect(() => {
    walineInstanceRef.current?.update(props);
  }, [props]); // dependencies parameter is an array

Question Website | Website URL

https://waline.js.org/cookbook/import/project.html#%E5%9C%A8-react-%E9%A1%B9%E7%9B%AE%E4%B8%AD%E5%AF% BC%E5%85%A5

@YieldRay YieldRay added the bug Something isn't working label Nov 27, 2023
@github-actions github-actions bot changed the title [Bug]: 文档中给出的 React 示例代码有一处小错误 [Bug]: 文档中给出的 React 示例代码有一处小错误 || [Bug]: There is a small error in the React sample code given in the document Nov 27, 2023
@github-actions github-actions bot changed the title [Bug]: 文档中给出的 React 示例代码有一处小错误 || [Bug]: There is a small error in the React sample code given in the document [Bug]: 文档中给出的 React 示例代码有一处小错误 || [Bug]: There is a small error in the React sample code given in the documentation Nov 27, 2023
@lizheming lizheming added the contribution welcome Contribution about current issue is welcomed label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contribution welcome Contribution about current issue is welcomed
Projects
None yet
Development

No branches or pull requests

2 participants