Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Comment sorting and disabling image upload settings in client don't seem to work. #2462

Closed
ScootRay opened this issue Apr 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ScootRay
Copy link

ScootRay commented Apr 29, 2024

问题描述 | Describe the bug

Comment sorting and disabling image upload settings in client don't seem to work.

I have them defined on the client side as:

 <script type="module">
    import { init } from 'https://unpkg.com/@waline/client@v3/dist/waline.js';

    init({
      el: '#waline',
      serverURL: 'https://test-comments.vercel.app',
      lang: 'en',
      dark: 'auto',
      login: 'disable',
      WalineCommentSorting: 'oldest',
      WalineImageUploader: 'false',
    });
  </script>

lang, dark and login are accepted and working just not the comment/uploading settings. Is there something else I should be doing?

Thanks, looks like a slick comment app!

Ray

问题网站 | Website URL

https://private.url

服务部署在哪里? | Where your waline deploy?

Vercel (Default)

数据存储在哪里?| Where your comment data store?

LeanCloud(https://leancloud.app)

@ScootRay ScootRay added the bug Something isn't working label Apr 29, 2024
@github-actions github-actions bot changed the title [Bug]: [Bug]: || [Bug]: Apr 29, 2024
@ScootRay ScootRay changed the title [Bug]: || [Bug]: [Bug]: || [Bug]:Comment sorting and image uploading options in client don't work Apr 29, 2024
@github-actions github-actions bot changed the title [Bug]: || [Bug]:Comment sorting and image uploading options in client don't work [Bug]: || [Bug]: Apr 29, 2024
@ScootRay ScootRay changed the title [Bug]: || [Bug]: [Bug]: Comment sorting and disabling image upload settings in client don't seem to work. Apr 29, 2024
@lizheming
Copy link
Collaborator

  1. It's named commentSorting, not WalineCommentSorting. https://waline.js.org/en/reference/client/props.html#commentsorting
  2. It's named imageUploader, not WalineImageUploader. And the value should be false, not 'false'

@ScootRay
Copy link
Author

Doh! That’s what I get for not getting much sleep. It’s all good now. Thank you muchly.

Am loving how elegant and easy Waline is.

Props!
Ray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants