Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 人机验证会成为刷评论的原因 || [Bug]: Human-machine verification will become the reason for brushing comments #2681

Closed
FrederickBun opened this issue Aug 22, 2024 · 2 comments · Fixed by #2682
Labels
bug Something isn't working

Comments

@FrederickBun
Copy link

FrederickBun commented Aug 22, 2024

问题描述 | Describe the bug

本人在捣鼓自己评论的时候,发现了这样的现象:

image

因为Waline按 Command/Control + Enter 会发送,而又人机验证的时候就会按几次有几个人机验证,而此时输入框还有内容,所以每一次人机验证完成都会带内容发送,一次完成这些人机验证之后将会发送很多消息从而达到刷屏

Screen.Recording.2024-08-22.at.10.35.17.PM.mov

后台就会出现这样的惨状

建议修复为人机验证完成前不允许发送过多消息

如果没有人机验证,那么也有可能因为卡顿而导致刷屏(差不多意思,只是说那个刷的少些)

Note

本人仅在自己的Waline上实验,未对其他用户造成攻击

Warning

在BUG修复前,请熊孩子不要捣乱

问题网站 | Website URL

https://comment.setbun.com/

服务部署在哪里? | Where your waline deploy?

Deta

数据存储在哪里?| Where your comment data store?

Deta Base


Problem description | Describe the bug

When I was tinkering with my comments, I discovered this phenomenon:

image

Because Waline presses Command/Control + Enter to send, and during human-computer verification, it will press several times for several human-computer verifications. At this time, the input box still has content, so every time the human-computer verification is completed, the content will be sent. After completing these human-machine verifications at once, many messages will be sent to achieve a refreshed screen.

Screen.Recording.2024-08-22.at.10.35.17.PM.mov

There will be such a tragic situation in the background

It is recommended to fix the problem of not allowing too many messages to be sent before human-machine verification is completed.

If there is no human-machine verification, it is possible that the screen will be refreshed due to lag (similar to the same meaning, it just means that the refresh rate is less)

Note

I only experimented on my own Waline and did not cause any attacks on other users.

Warning

Please don’t cause trouble until the bug is fixed.

Question Website | Website URL

https://comment.setbun.com/

Where is the service deployed? | Where your waline deploy?

Deta

Where is the data stored? | Where your comment data store?

Deta Base

@FrederickBun FrederickBun added the bug Something isn't working label Aug 22, 2024
@github-actions github-actions bot changed the title [Bug]: 人机验证会成为刷评论的原因 [Bug]: 人机验证会成为刷评论的原因 || [Bug]: Human-machine verification will become the reason for brushing comments Aug 22, 2024
@lizheming
Copy link
Collaborator

lizheming commented Aug 23, 2024

尝试了下,应该属于评论发送过程中的防止重复发送的问题,后续优化下这块。


After trying it, it seems that it is a problem of preventing repeated sending in the process of sending comments. I will optimize this in the future.

@jeremy0519
Copy link

jeremy0519 commented Aug 23, 2024

用IPQPS是不是就可以了?


Is it enough to use IPQPS?

lizheming added a commit that referenced this issue Aug 24, 2024
@lizheming lizheming linked a pull request Aug 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants