moar version 1.30.0 crashed on macOS #259

ciscohack · 2024-12-09T08:04:08Z

moar crash with follow syntax search and freeze at crash prompt

 ug 'stuck' asa.txt | ug 'loop'                                                                                                                                                                                           ✔
^[[?1049h^[[?1006;1000l^[[?25l^[]11;?^GPlease post the following report at <https://github.com/walles/moar/issues>,
or e-mail it to [email protected].

Version: v1.30.0
LANG   : en_US.UTF-8
TERM   : tmux-256color
MOAR   : -colors=16M --render-unprintable=whitespace -mousemode=select
EDITOR :

GOOS    : darwin
GOARCH  : arm64
Compiler: gc
NumCPU  : 12

panic: runtime error: index out of range [-1] [recovered]
        panic: runtime error: index out of range [-1] [recovered]
        panic: runtime error: index out of range [-1]

goroutine 1 [running]:
main.main.func1()
        github.com/walles/moar/moar.go:598 +0x150
panic({0x1046b9560?, 0x14000134498?})
        runtime/panic.go:785 +0x124
main.startPaging.func1()
        github.com/walles/moar/moar.go:652 +0x114
panic({0x1046b9560?, 0x14000134498?})
        runtime/panic.go:785 +0x124
github.com/walles/moar/m.(*Pager).decorateLine(0x1400028a000, 0x140004481e0, {0x14000482480, 0x7, 0x7}, {0x140004481d8, 0x0, {0x104406a71, 0x5}, 0x1, ...})
        github.com/walles/moar/m/screenLines.go:362 +0xba4
github.com/walles/moar/m.(*Pager).renderLine(0x1400028a000, 0x1400035e260, {0x0}, {0x140004481d8, 0x0, {0x104406a71, 0x5}, 0x1, {0x0, 0x0, ...}})
        github.com/walles/moar/m/screenLines.go:240 +0x27c
github.com/walles/moar/m.(*scrollPositionInternal).handlePositiveDeltaScreenLines(0x1400028a020, 0x1400028a000)
        github.com/walles/moar/m/scrollPosition.go:142 +0xc0
github.com/walles/moar/m.(*scrollPositionInternal).canonicalize(0x1400028a020, 0x1400028a000)
        github.com/walles/moar/m/scrollPosition.go:255 +0x198
github.com/walles/moar/m.(*Pager).lineNumber(...)
        github.com/walles/moar/m/scrollPosition.go:277
github.com/walles/moar/m.(*Pager).renderLines(0x1400028a000)
        github.com/walles/moar/m/screenLines.go:118 +0x64
github.com/walles/moar/m.(*Pager).renderScreenLines(0x1400028a000)
        github.com/walles/moar/m/screenLines.go:77 +0x28
github.com/walles/moar/m.(*Pager).redraw(0x1400028a000, {0x0, 0x0})
        github.com/walles/moar/m/screenLines.go:42 +0x4c
github.com/walles/moar/m.(*Pager).StartPaging(0x1400028a000, {0x1046d2638, 0x1400015c0e0}, 0x1400035e0c0, 0x1400048f430)
        github.com/walles/moar/m/pager.go:350 +0x2d0
main.startPaging(0x14000112230?, {0x1046d2638?, 0x1400015c0e0?}, 0x1046cd750?, 0x14000170001?)
        github.com/walles/moar/moar.go:670 +0x54
main.main()
        github.com/walles/moar/moar.go:623 +0x234

The text was updated successfully, but these errors were encountered:

walles · 2024-12-19T05:38:16Z

I've been able to reproduce this crash in a test by setting the screen width to 0.

Seems you are in tmux, is that right?

I wonder what would make tmux report zero width terminal...

ciscohack · 2024-12-19T09:52:40Z

I've been able to reproduce this crash in a test by setting the screen width to 0.

Seems you are in tmux, is that right?

I wonder what would make tmux report zero width terminal...

Yes i am using tmux.. not sure on terminal part

walles · 2024-12-19T20:33:18Z

Inside the tmux session where this crash happens:

Does this crash happen every time or does it sometimes work?
What if you just view some file in moar like moar /etc/services, does that also crash?
Can you try tput cols and post the output here?
Which terminal program are you using?

It's strange that you see ^[[?1049h^[[?1006;1000l^[[?25l^[]11;?^G, which is part of moar's terminal init sequence.

Kind of like something blocking moar from talking to the terminal.

ciscohack · 2024-12-20T05:34:47Z

@walles

=> I tried 2 times and crash happened 2 times then i didn't tried.
=> tried moar /etc/services and this didn't cause crash
=> tput cols result output 172
=> i am using iterm2

Relates to #259. I don't understand how this could happen, but this should at least take us closer to the source.

To improve diagnoability of #259.

walles · 2024-12-31T08:13:59Z

Do you have a .ugrep config file?

If you do, could you share it here?

ciscohack · 2024-12-31T10:14:39Z

Do you have a .ugrep config file?

If you do, could you share it here?

bkp.ugrep.zip

Here you go

For improved debugability of #259.

walles · 2025-01-01T11:45:36Z

Do you have a ~/.tmux.conf or a /etc/tmux file?

If you could upload those here as well I'd like to have a look!

ciscohack · 2025-01-01T15:45:43Z

Do you have a ~/.tmux.conf or a /etc/tmux file?

If you could upload those here as well I'd like to have a look!

https://github.com/gpakosz/.tmux

this is what i am using just minor keybinding change nothing else ..so you can use this

Ref: #259

walles · 2025-01-05T23:36:27Z

Can you repro with v1.31.0? And put the crash message in this ticket?

https://github.com/walles/moar/releases/tag/v1.31.0

The crash message in this release contains more information that I hope will tell me something about what's going on.

ciscohack · 2025-01-06T05:05:17Z

Can you repro with v1.31.0? And put the crash message in this ticket?

https://github.com/walles/moar/releases/tag/v1.31.0

The crash message in this release contains more information that I hope will tell me something about what's going on.

I am running moar v1.31.1 now and i am now travelling will be away from my system for longer duration

ciscohack · 2025-01-07T05:47:26Z

some how i got access to my system and tested 1.31.0 and issue is still there

or e-mail it to [email protected].

Version: v1.31.0
LANG   : en_US.UTF-8
TERM   : tmux-256color
MOAR   : -colors=16M --render-unprintable=whitespace -mousemode=select
EDITOR :

GOOS    : darwin
GOARCH  : arm64
Compiler: gc
NumCPU  : 12

Stdin  is a terminal: false
Stdout is a terminal: true

time="Jan  7 11:16:40.873573" level=info msg="Input stream is assumed to be uncompressed"
time="Jan  7 11:16:40.874763" level=info msg="ttyin terminal state: &{state:{termios:{Iflag:10240 Oflag:2 Cflag:19200 Lflag:67 Cc:[4 255 255 127 23 21 18 255 3 28 26 25 17 19 22 15 1 0 20 255] Ispeed:9600 Ospeed:9600}}}"
time="Jan  7 11:16:40.874777" level=info msg="ttyout terminal state: &{state:{termios:{Iflag:10240 Oflag:2 Cflag:19200 Lflag:67 Cc:[4 255 255 127 23 21 18 255 3 28 26 25 17 19 22 15 1 0 20 255] Ispeed:9600 Ospeed:9600}}}"
time="Jan  7 11:16:40.874915" level=info msg="Entering Twin main loop..."
time="Jan  7 11:16:40.875382" level=info msg="Pager starting"
time="Jan  7 11:16:40.875433" level=info msg="Entering pager main loop..."
time="Jan  7 11:16:40.875468" level=info msg="ttyin read error, twin giving up: EOF"

Panic recovery timestamp: 2025-01-07 11:16:40.875592 +0530 IST m=+0.020610126

panic: Got zero screen size: 0 x 0 [recovered]
        panic: Got zero screen size: 0 x 0 [recovered]
        panic: Got zero screen size: 0 x 0

goroutine 1 [running]:
main.main.func1()
        github.com/walles/moar/moar.go:610 +0x200
panic({0x10131ba60?, 0x14000306280?})
        runtime/panic.go:785 +0x124
main.startPaging.func1()
        github.com/walles/moar/moar.go:665 +0x114
panic({0x10131ba60?, 0x14000306280?})
        runtime/panic.go:785 +0x124
github.com/walles/moar/twin.(*UnixScreen).Size(0x1400023c000)
        github.com/walles/moar/twin/screen.go:574 +0x208
github.com/walles/moar/twin.(*UnixScreen).Clear(0x1400023c000)
        github.com/walles/moar/twin/screen.go:684 +0x80
github.com/walles/moar/m.(*Pager).redraw(0x14000312000, {0x0, 0x0})
        github.com/walles/moar/m/screenLines.go:37 +0x40
github.com/walles/moar/m.(*Pager).StartPaging(0x14000312000, {0x101366ab8, 0x1400023c000}, 0x14000492400, 0x140003f3240)
        github.com/walles/moar/m/pager.go:351 +0x2cc

walles · 2025-01-07T06:17:10Z

More questions:

Which version of ITerm2 are you using?
If you try another terminal (not ITerm2), do you still get this crash?
Does less work if you invoke it the same way (through ug)?
Do you know when this started happening? Months ago? Days ago? Did you change anything at that time?

I need to look into what these numbers mean exactly, but the terminal state is very different on your system compared to mine. Based on the termios man page and termios.h.

Yours (broken):

terminal state:
&{state:{termios:{Iflag:10240 Oflag:2 Cflag:19200 Lflag:67 Cc:[4 255 255 127 23 21 18 255 3 28 26 25 17 19 22 15 1 0 20 255] Ispeed:9600 Ospeed:9600}}}

Mine (works):

terminal state:
&{state:{termios:{Iflag:24580 Oflag:6 Cflag:19200 Lflag:536870983 Cc:[4 255 255 127 23 21 18 0 3 28 26 25 17 19 22 15 1 0 20 0] Ispeed:38400 Ospeed:38400}}}

ciscohack · 2025-01-07T14:51:25Z

@walles Now i am using ghostty terminal version 1.0.1

Which version of ITerm2 are you using? ---> ghostty terminal version 1.0.1
If you try another terminal (not ITerm2), do you still get this crash? earlier tried other terminal
Does less work if you invoke it the same way (through ug)? yes less working fine with no crash
Do you know when this started happening? Months ago? Days ago? Did you change anything at that time?
that i am not very sure

one question why in trace or any freeze case ctrl + c or z or ESC not letting moar to exit from prompt...i think we should have way to force exit moar in any case

walles added a commit that referenced this issue Dec 31, 2024

Fail earlier on zero screen size

f28edc8

Relates to #259. I don't understand how this could happen, but this should at least take us closer to the source.

walles added a commit that referenced this issue Dec 31, 2024

Add terminality to panic message

d88e872

To improve diagnoability of #259.

walles added a commit that referenced this issue Jan 1, 2025

Log terminal state after terminal setup

a86f361

For improved debugability of #259.

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

walles added a commit that referenced this issue Jan 5, 2025

Improve TTY debugability

69a7f5d

Ref: #259

walles mentioned this issue Jan 5, 2025

moar 1.31.0 Homebrew/homebrew-core#203293

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

moar version 1.30.0 crashed on macOS #259

moar version 1.30.0 crashed on macOS #259

ciscohack commented Dec 9, 2024 •

edited by walles

Loading

walles commented Dec 19, 2024 •

edited

Loading

ciscohack commented Dec 19, 2024 •

edited

Loading

walles commented Dec 19, 2024

ciscohack commented Dec 20, 2024

walles commented Dec 31, 2024

ciscohack commented Dec 31, 2024

walles commented Jan 1, 2025

ciscohack commented Jan 1, 2025 •

edited

Loading

This comment was marked as outdated.

This comment was marked as resolved.

walles commented Jan 5, 2025

ciscohack commented Jan 6, 2025

ciscohack commented Jan 7, 2025 •

edited by walles

Loading

walles commented Jan 7, 2025

ciscohack commented Jan 7, 2025 •

edited

Loading

moar version 1.30.0 crashed on macOS #259

moar version 1.30.0 crashed on macOS #259

Comments

ciscohack commented Dec 9, 2024 • edited by walles Loading

walles commented Dec 19, 2024 • edited Loading

ciscohack commented Dec 19, 2024 • edited Loading

walles commented Dec 19, 2024

ciscohack commented Dec 20, 2024

walles commented Dec 31, 2024

ciscohack commented Dec 31, 2024

walles commented Jan 1, 2025

ciscohack commented Jan 1, 2025 • edited Loading

This comment was marked as outdated.

This comment was marked as resolved.

walles commented Jan 5, 2025

ciscohack commented Jan 6, 2025

ciscohack commented Jan 7, 2025 • edited by walles Loading

walles commented Jan 7, 2025

ciscohack commented Jan 7, 2025 • edited Loading

ciscohack commented Dec 9, 2024 •

edited by walles

Loading

walles commented Dec 19, 2024 •

edited

Loading

ciscohack commented Dec 19, 2024 •

edited

Loading

ciscohack commented Jan 1, 2025 •

edited

Loading

ciscohack commented Jan 7, 2025 •

edited by walles

Loading

ciscohack commented Jan 7, 2025 •

edited

Loading