Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work properly unless ESLint is a peer Dependency! #30

Closed
baer opened this issue Aug 25, 2015 · 6 comments
Closed

Does not work properly unless ESLint is a peer Dependency! #30

baer opened this issue Aug 25, 2015 · 6 comments

Comments

@baer
Copy link
Contributor

baer commented Aug 25, 2015

No description provided.

@ryan-roemer
Copy link
Contributor

We could also investigate process.env.PATH mutation as a potential option as well to add to the documentation...

@baer
Copy link
Contributor Author

baer commented Aug 25, 2015

Can you elaborate on that? This issue is specific to the following:

package.json

dependencies: {
  "eslint-config-defaults": "4.2.0"
}
eslint .
/Users/ebaer/.nvm/versions/node/v0.12.7/lib/node_modules/eslint/lib/config.js:171
                    throw e;
                          ^
Error: Cannot find module 'eslint-config-defaults/configurations/walmart/es5-browser'
Referenced from: /Users/ebaer/dev/walmart/tmp/.eslintrc
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at readConfigFromFile (/Users/ebaer/.nvm/versions/node/v0.12.7/lib/node_modules/eslint/lib/config.js:113:44)
    at loadConfig (/Users/ebaer/.nvm/versions/node/v0.12.7/lib/node_modules/eslint/lib/config.js:134:22)
    at /Users/ebaer/.nvm/versions/node/v0.12.7/lib/node_modules/eslint/lib/config.js:165:46
    at Array.reduceRight (native)
    at loadConfig (/Users/ebaer/.nvm/versions/node/v0.12.7/lib/node_modules/eslint/lib/config.js:149:36)
    at getLocalConfig (/Users/ebaer/.nvm/versions/node/v0.12.7/lib/node_modules/eslint/lib/config.js:273:23)

@baer
Copy link
Contributor Author

baer commented Aug 25, 2015

Might be related to #16 actually.

@BaoDelta
Copy link

Hi, I see this bug in 5.0.0 as well.

Using .eslintrc from README

---
"extends":
  - "defaults/configurations/walmart/es6-browser"

will raise the error

node_modules/eslint/lib/config.js:171
                    throw e;
                          ^
Error: Cannot find module 'eslint-config-defaults/configurations/walmart/es6-browser'

Does anyone have a workaround? Thanks

@baer
Copy link
Contributor Author

baer commented Oct 1, 2015

@baodang Your issue is actually related to #33 which has been closed. You should be good to go on the latest.

@baer
Copy link
Contributor Author

baer commented Dec 23, 2015

Closing this and documenting here: #43

I'll update the README to reflect this known issue

@baer baer closed this as completed Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants