Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Todo 수정모드 리팩터링 #19

Open
salmontaker opened this issue Aug 24, 2023 · 0 comments
Open

Todo 수정모드 리팩터링 #19

salmontaker opened this issue Aug 24, 2023 · 0 comments
Labels
refactor 리팩토링

Comments

@salmontaker
Copy link
Contributor

salmontaker commented Aug 24, 2023 •
edited
Loading

[리팩토링 제안]
초기 개발에는 이렇게 추상화 하지 않고 분기처리를 하는 것이 가독성이 좋아보입니다.

리팩토링을 한다고 하면, 별도의 컴포넌트로 추상화를 해도 좋을 것 같다는 생각이 들었습니다. isEditMode를 prop으로 받는 컴포넌트로요

Originally posted by @SeungrokYoon in #13 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor 리팩토링
Projects
Week1 - 간단한 투두리스트 프로젝트
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@salmontaker