Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 - [x/act V2]: Add ExpectedExpressions to MsgNewAction #743

Closed
backsapc opened this issue Aug 30, 2024 · 0 comments · Fixed by #791
Closed

2 - [x/act V2]: Add ExpectedExpressions to MsgNewAction #743

backsapc opened this issue Aug 30, 2024 · 0 comments · Fixed by #791
Assignees
@mn13
Labels
protocol x-act Related to `x/act` module

Comments

@backsapc
Copy link
Contributor

backsapc commented Aug 30, 2024 •
edited by artur-abliazimov
Loading

Source: abstract
To mitigate the risks of unexpected results when changing Action Expressions during Action creation, we are adding new fields to MsgNewAction. If the Expressions sent with the message differ from the Expressions on-chain, we will reject the transaction (Tx).

  1. Add ExpectedApprovalExpression Expression field to MsgNewAction
  2. Add ExpectedRejectExpression Expression field to MsgNewAction

Note:
Testing is dependent from: https://github.com/orgs/warden-protocol/projects/12/views/1?pane=issue&itemId=78576799
@backsapc backsapc changed the title Draft: Add ExpectedExpressions to MsgNewAction Add ExpectedExpressions to MsgNewAction Sep 4, 2024
@backsapc backsapc added protocol x-act Related to `x/act` module labels Sep 4, 2024
@artur-abliazimov artur-abliazimov changed the title Add ExpectedExpressions to MsgNewAction 2. Add ExpectedExpressions to MsgNewAction Sep 4, 2024
@artur-abliazimov artur-abliazimov changed the title 2. Add ExpectedExpressions to MsgNewAction 2. x/act V2: Add ExpectedExpressions to MsgNewAction Sep 4, 2024
@artur-abliazimov artur-abliazimov changed the title 2. x/act V2: Add ExpectedExpressions to MsgNewAction 2 - [x/act V2]: Add ExpectedExpressions to MsgNewAction Sep 4, 2024
@mn13 mn13 self-assigned this Sep 5, 2024
@mn13 mn13 linked a pull request Sep 5, 2024 that will close this issue
add expected approval&reject expressions to MsgNewAction #791
Merged
@coderabbitai coderabbitai bot mentioned this issue Sep 5, 2024
Merged
@mn13 mn13 closed this as completed in #791 Sep 5, 2024
@coderabbitai coderabbitai bot mentioned this issue Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mn13 mn13

Labels
protocol x-act Related to `x/act` module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add expected approval&reject expressions to MsgNewAction warden-protocol/wardenprotocol
2 participants
@mn13 @backsapc