Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user when not all text search results are shown #235

Open
rfay opened this issue Jun 11, 2015 · 4 comments
Open

Notify user when not all text search results are shown #235

rfay opened this issue Jun 11, 2015 · 4 comments
Milestone

Comments

@rfay
Copy link
Contributor

rfay commented Jun 11, 2015

In the text search we currently only show the first 50 results. If there are more than 50 we should do a toast to show how many more there are. Something like "Only 50 of 198 results are shown. Please use a more specific search."

@rfay rfay added this to the 1.5.1 milestone Jun 11, 2015
@PattaFeuFeu PattaFeuFeu modified the milestones: 1.5.1, 2.1.0 Jul 5, 2018
@sgelb
Copy link
Collaborator

sgelb commented Aug 18, 2018

Currently, the REST-API does not provide a total count of search results (see relevant warmshowers.org drupal code). And as a user, I would be pretty annoyed by such a message. If there are more results for my search query, I want to see them.

What about lazy loading/endless scrolling, e.g. using Google Paging library? This could also reduce bandwidth use as it allows to lower the current limit of 100.

Examples are provided here.

@saemy
Copy link
Collaborator

saemy commented Aug 20, 2018

I like the idea of adding a endless scrolling feature. And it will work for text search results.
Unfortunately, at the moment it won't work for message threads and messages within a thread (see #272) and user searches by location as those request either lack limit/offset parameters or handle them incorrectly.

Also, it seems that the Google paging library is closed source, isn't it? We are trying to move away from such libraries (see #279). Is there any FLOSS library that does the same?

@saemy
Copy link
Collaborator

saemy commented Aug 20, 2018

Sorry for closing this.

@saemy saemy reopened this Aug 20, 2018
@sgelb
Copy link
Collaborator

sgelb commented Aug 20, 2018

Google Paging is released under Apache Version 2, see source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants