Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Unlink linkdef logs need additional context #634

Open
ricochet opened this issue May 25, 2023 · 2 comments
Open

[BUG] Unlink linkdef logs need additional context #634

ricochet opened this issue May 25, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed pinned Should not be removed as stale over time

Comments

@ricochet
Copy link

Describe the bug

The unlink linkdef logs do not include context for which actor was unlinked.

To Reproduce

Steps to reproduce the behavior:

  1. Link actor
  2. Unlink actor
  3. Review host logs

Expected behavior

It should be clear which actor was unlinked. All logs in this flow show be updated.

Environment (please complete the following information)

  • OS: MacOS, Linux
  • Arch: aarch64
  • wasmCloud Version: 0.62.0

Additional context

Testing with an actor whose put link fails might be another user flow to observe and test.
@ricochet ricochet added bug Something isn't working help wanted Extra attention is needed labels May 25, 2023
@stale
Copy link

stale bot commented Jul 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@stale stale bot added the stale label Jul 24, 2023
@stale stale bot closed this as completed Jul 31, 2023
@brooksmtownsend brooksmtownsend added good first issue Good for newcomers and removed stale labels Jul 31, 2023
@brooksmtownsend
Copy link
Member

This is a quick-win and we should totally do it. Marking as good-first-issue thanks to it being very low barrier to entry 😄

@connorsmith256 connorsmith256 added the pinned Should not be removed as stale over time label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed pinned Should not be removed as stale over time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ricochet @connorsmith256 @brooksmtownsend