Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable (a subset of) test suite to run without IDAES extensions #6

Open
lbianchi-lbl opened this issue May 2, 2024 · 1 comment
Open

Comments

@lbianchi-lbl
Copy link
Contributor

⚠️ This is just a naive thought for the sake of discussion, and might not be worth the effort (or be feasible at all) ⚠️

  • Currently, our use of get_solver() from WaterTAP means that idaes get-extensions needs to be run before being able to access a suitable solver for running the tests. This causes idaes-pse (which is a requirement for running idaes get-extensions) to be a required dependency for testing
  • Following Allow solver to be supplied by clients instead of hard-coding it from IDAES or WaterTAP #3, this need might be relaxed, potentially opening the possibility of running the tests without having to rely on IDAES extensions
  • e.g. if the sample models used are solvable without the IDAES Ipopt, then we could use the ipopt from an alternative source such as Conda, which would remove the idaes-pse requirement for running the tests (or at least those tests that are pure Pyomo, as opposed to e.g. more integration-type tests using WaterTAP flowsheets)

Questions

  • Is this feasible, considering the models being used for (non-WaterTAP) tests in our test suite?
  • Is this worth considering? i.e. would it be helpful to ensure our tests can be run with non-IDAES Ipopt implementations, e.g. facilitating an eventual pyomo.contrib inclusion?
@bknueven
Copy link
Contributor

bknueven commented May 3, 2024

The non-WaterTAP tests are simple models which should be solvable with the Conda ipopt, or any optimization solver supported by Pyomo, e.g., it looks like we could probably install a community version of a commercial MIP solver, or HiGHS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants