refactor: format:js should be used without args (#9266)

web-infra-dev · Feb 12, 2025 · 9f82074 · 9f82074 · github-actions · Feb 12, 2025
1 parent 7fca533
commit 9f82074
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lint-staged.config.mjs b/lint-staged.config.mjs
@@ -1,6 +1,6 @@
 export default {
 	"*.rs": "rustfmt --edition 2021",
-	"*.{ts,tsx,js,mjs}": "pnpm run format:js",
+	"*.{ts,tsx,js,mjs}": "node ./node_modules/prettier/bin/prettier.cjs --write",
 	"*.toml": "npx @taplo/cli format",
 	"*.{ts,tsx,js,cts,cjs,mts,mjs}": [
 		"pnpm run lint:js",

diff --git a/package.json b/package.json
@@ -21,8 +21,8 @@
     "build:viewer": "pnpm --filter \"@rspack/*\" build:viewer",
     "test:js": "pnpm -r run test",
     "format:rs": "cargo fmt --all",
-    "format:js": "node ./node_modules/prettier/bin/prettier.cjs --write",
-    "format-ci:js": "node ./node_modules/prettier/bin/prettier.cjs \"packages/**/src/**/*.{ts,tsx,js}\" \"crates/rspack_plugin_runtime/**/*.{ts,js}\" \"scripts/**/*.{cjs,mjs,js}\"  \"x.mjs\" \"x\" --check",
+    "format:js": "pnpm run format-ci:js --write",
+    "format-ci:js": "node ./node_modules/prettier/bin/prettier.cjs \"packages/**/src/**/*.{ts,tsx,js}\" \"crates/rspack_plugin_runtime/**/*.{ts,js}\" \"scripts/**/*.{cjs,mjs,js}\"  \"*.mjs\" \"x\" --check",
     "format-ci:toml": "npx @taplo/cli format --check '.cargo/*.toml' './crates/**/Cargo.toml' './Cargo.toml'",
     "format:toml": "npx @taplo/cli format '.cargo/*.toml' './crates/**/Cargo.toml' './Cargo.toml'",
     "lint:js": "pnpm run lint-ci:js --write",
suite	result
modernjs	✅ success
rspress	✅ success
rslib	✅ success
rsbuild	❌ failure
rsdoctor	❌ failure
examples	✅ success
devserver	✅ success
nuxt	✅ success
Name	Base (2025-02-12 03cc6cf)	Current	Change
10000_big_production-mode_disable-minimize + exec	38.8 s ± 1.01 s	39.1 s ± 746 ms	+0.76 %
10000_development-mode + exec	1.88 s ± 100 ms	1.85 s ± 172 ms	-1.49 %
10000_development-mode_hmr + exec	685 ms ± 6.4 ms	681 ms ± 9.5 ms	-0.62 %
10000_production-mode + exec	2.34 s ± 90 ms	2.34 s ± 163 ms	+0.11 %
10000_production-mode_persistent-cold + exec	2.45 s ± 62 ms	2.42 s ± 23 ms	-1.35 %
10000_production-mode_persistent-hot + exec	1.68 s ± 167 ms	1.65 s ± 53 ms	-1.72 %
arco-pro_development-mode + exec	1.82 s ± 103 ms	1.78 s ± 94 ms	-1.87 %
arco-pro_development-mode_hmr + exec	389 ms ± 1.9 ms	388 ms ± 0.8 ms	-0.40 %
arco-pro_production-mode + exec	3.63 s ± 161 ms	3.69 s ± 121 ms	+1.67 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.71 s ± 33 ms	3.75 s ± 105 ms	+1.15 %
arco-pro_production-mode_persistent-cold + exec	3.81 s ± 223 ms	3.74 s ± 150 ms	-1.79 %
arco-pro_production-mode_persistent-hot + exec	2.32 s ± 52 ms	2.41 s ± 158 ms	+3.80 %
arco-pro_production-mode_traverse-chunk-modules + exec	3.7 s ± 122 ms	3.69 s ± 70 ms	-0.36 %
large-dyn-imports_development-mode + exec	2.16 s ± 38 ms	2.13 s ± 48 ms	-1.32 %
large-dyn-imports_production-mode + exec	2.16 s ± 27 ms	2.17 s ± 50 ms	+0.84 %
threejs_development-mode_10x + exec	1.57 s ± 49 ms	1.54 s ± 22 ms	-1.84 %
threejs_development-mode_10x_hmr + exec	788 ms ± 7.2 ms	776 ms ± 6.9 ms	-1.58 %
threejs_production-mode_10x + exec	5.24 s ± 88 ms	5.24 s ± 123 ms	-0.11 %
threejs_production-mode_10x_persistent-cold + exec	5.3 s ± 81 ms	5.36 s ± 394 ms	+1.09 %
threejs_production-mode_10x_persistent-hot + exec	4.54 s ± 144 ms	4.53 s ± 199 ms	-0.37 %
10000_big_production-mode_disable-minimize + rss memory	8691 MiB ± 24.9 MiB	8696 MiB ± 55 MiB	+0.05 %
10000_development-mode + rss memory	656 MiB ± 28.5 MiB	653 MiB ± 33.5 MiB	-0.53 %
10000_development-mode_hmr + rss memory	1286 MiB ± 174 MiB	1198 MiB ± 155 MiB	-6.82 %
10000_production-mode + rss memory	627 MiB ± 20.1 MiB	626 MiB ± 17.7 MiB	-0.05 %
10000_production-mode_persistent-cold + rss memory	740 MiB ± 25.8 MiB	744 MiB ± 14.9 MiB	+0.50 %
10000_production-mode_persistent-hot + rss memory	717 MiB ± 25.4 MiB	715 MiB ± 16.7 MiB	-0.30 %
arco-pro_development-mode + rss memory	560 MiB ± 17.8 MiB	565 MiB ± 27.1 MiB	+0.91 %
arco-pro_development-mode_hmr + rss memory	637 MiB ± 83 MiB	678 MiB ± 24.8 MiB	+6.37 %
arco-pro_production-mode + rss memory	716 MiB ± 24.8 MiB	705 MiB ± 16.4 MiB	-1.51 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory	727 MiB ± 15.4 MiB	721 MiB ± 36.2 MiB	-0.84 %
arco-pro_production-mode_persistent-cold + rss memory	837 MiB ± 63.8 MiB	835 MiB ± 21.8 MiB	-0.28 %
arco-pro_production-mode_persistent-hot + rss memory	706 MiB ± 19.6 MiB	699 MiB ± 11 MiB	-1.02 %
arco-pro_production-mode_traverse-chunk-modules + rss memory	735 MiB ± 23.3 MiB	720 MiB ± 40.7 MiB	-2.07 %
large-dyn-imports_development-mode + rss memory	640 MiB ± 5.5 MiB	634 MiB ± 5.57 MiB	-0.97 %
large-dyn-imports_production-mode + rss memory	527 MiB ± 6.62 MiB	522 MiB ± 6.34 MiB	-1.01 %
threejs_development-mode_10x + rss memory	546 MiB ± 15.1 MiB	550 MiB ± 17 MiB	+0.87 %
threejs_development-mode_10x_hmr + rss memory	1183 MiB ± 111 MiB	1142 MiB ± 150 MiB	-3.46 %
threejs_production-mode_10x + rss memory	834 MiB ± 45 MiB	829 MiB ± 48.6 MiB	-0.54 %
threejs_production-mode_10x_persistent-cold + rss memory	962 MiB ± 46.9 MiB	951 MiB ± 16.7 MiB	-1.16 %
threejs_production-mode_10x_persistent-hot + rss memory	878 MiB ± 35 MiB	867 MiB ± 24.7 MiB	-1.24 %