Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressPlugin - weird result on arco-pro example #4890

Closed
xc2 opened this issue Dec 5, 2023 · 2 comments
Closed

ProgressPlugin - weird result on arco-pro example #4890

xc2 opened this issue Dec 5, 2023 · 2 comments
Labels
bug Something isn't working stale

Comments

@xc2
Copy link
Collaborator

xc2 commented Dec 5, 2023

System Info

  System:
    OS: macOS 14.0
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 173.95 MB / 32.00 GB
    Shell: 3.6.1 - /usr/local/bin/fish
  Binaries:
    Node: 20.10.0 - ~/.managed/n/bin/node
    npm: 10.2.3 - ~/.managed/n/bin/npm
  Browsers:
    Chrome: 119.0.6045.199
    Firefox: 116.0.2
    Safari: 17.0
  npmPackages:
    @rspack/cli: workspace:* => 0.4.1 
    @rspack/core: workspace:* => 0.4.1 
    @rspack/plugin-html: workspace:* => 0.4.1 
    @rspack/plugin-react-refresh: workspace:* => 0.4.1 

Details

when i was building arco-pro example with progress profile output, i found it somehow weird.

image
diff --git a/examples/arco-pro/rspack.config.js b/examples/arco-pro/rspack.config.js
index fc65bb451..c296ead08 100644
--- a/examples/arco-pro/rspack.config.js
+++ b/examples/arco-pro/rspack.config.js
@@ -112,7 +112,9 @@ const config = {
                        favicon: path.join(__dirname, "public", "favicon.ico")
                }),
                new ReactRefreshPlugin(),
-           new rspack.ProgressPlugin()
+         new rspack.ProgressPlugin({
+                 profile: true
+         })
        ],
        infrastructureLogging: {
                debug: false

it told building a small css nprogress/nprogress.css takes long.

when i commented out importing nprogress/nprogress.css and ../assets/header-banner.png, the total cost didn't change and an other module color-name became the heavy thing.

image
diff --git a/examples/arco-pro/rspack.config.js b/examples/arco-pro/rspack.config.js
index fc65bb451..c296ead08 100644
--- a/examples/arco-pro/rspack.config.js
+++ b/examples/arco-pro/rspack.config.js
@@ -112,7 +112,9 @@ const config = {
                        favicon: path.join(__dirname, "public", "favicon.ico")
                }),
                new ReactRefreshPlugin(),
-           new rspack.ProgressPlugin()
+         new rspack.ProgressPlugin({
+                 profile: true
+         })
        ],
        infrastructureLogging: {
                debug: false
diff --git a/examples/arco-pro/src/pages/user/info/style/index.module.less b/examples/arco-pro/src/pages/user/info/style/index.module.less
index 491fe2427..62e55cc3f 100644
--- a/examples/arco-pro/src/pages/user/info/style/index.module.less
+++ b/examples/arco-pro/src/pages/user/info/style/index.module.less
@@ -29,7 +29,6 @@
 }
 
 .header::after {
-  background: url('../assets/header-banner.png') no-repeat;
   background-size: 100%;
   height: 200px;
   width: 100%;
diff --git a/examples/arco-pro/src/style/global.less b/examples/arco-pro/src/style/global.less
index 2fa5f9d80..1e8ae5f59 100644
--- a/examples/arco-pro/src/style/global.less
+++ b/examples/arco-pro/src/style/global.less
@@ -1,5 +1,4 @@
 @import '@arco-themes/react-arco-pro/index.less';
-@import 'nprogress/nprogress.css';
 
 html,
 body {

Reproduce link

No response

Reproduce Steps

as above

@xc2 xc2 added bug Something isn't working pending triage The issue/PR is currently untouched. labels Dec 5, 2023
@xc2 xc2 changed the title ProgressPlugin - ProgressPlugin - weird result on arco-pro example Dec 5, 2023
@jerrykingxyz jerrykingxyz removed the pending triage The issue/PR is currently untouched. label Dec 25, 2023
Copy link

stale bot commented Feb 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Feb 23, 2024
@xc2 xc2 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
@xc2
Copy link
Collaborator Author

xc2 commented Apr 29, 2024

Close as duplicated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants