Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: speedup ci by skip codegen-units = 1 #9257

Closed
wants to merge 2 commits into from
Closed

perf: speedup ci by skip codegen-units = 1 #9257

wants to merge 2 commits into from

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Feb 12, 2025 •
edited
Loading

Summary

codegen-units = 1 doesn't bring too much performance gain but will slow build a lot, so only enable it for release-prod

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels Feb 12, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 12, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 042154d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67acb09db94769000873afdc

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 12, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9257 will not alter performance

Comparing yj/speed-ci (042154d) with main (9f82074)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 6 untouched benchmarks

@hardfist hardfist force-pushed the yj/speed-ci branch 2 times, most recently from 9fead81 to 4287560 Compare February 12, 2025 07:44
h-a-n-a
h-a-n-a previously approved these changes Feb 12, 2025
View reviewed changes
@hardfist hardfist force-pushed the yj/speed-ci branch 2 times, most recently from 55bf538 to e282e59 Compare February 12, 2025 14:20
@hardfist hardfist closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a left review comments

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz is a code owner

Assignees
No one assigned
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardfist @h-a-n-a