Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: one shot ref for class instance #9267

Merged
merged 2 commits into from
Feb 13, 2025
Merged

perf: one shot ref for class instance #9267

merged 2 commits into from
Feb 13, 2025

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Feb 12, 2025

Summary

OneShotInstranceRef will store the raw pointer for value which napi wrap. It will reduce a napi unwrap call, when get the wrapped value.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 12, 2025
Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c9a2c1f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67aca9456c46d50008b0637d

Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #9267 will improve performances by 8.17%

Comparing perf-one-shot-ref (c9a2c1f) with main (9f82074)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 1 improvements
✅ 5 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
Traverse module graph by connections 381.2 µs 352.4 µs +8.17%

@SyMind SyMind force-pushed the perf-one-shot-ref branch 2 times, most recently from ae36eb3 to 342ebb7 Compare February 12, 2025 13:58
@SyMind SyMind merged commit a8461f4 into main Feb 13, 2025
33 checks passed
@SyMind SyMind deleted the perf-one-shot-ref branch February 13, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants