Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): enable cfa #9470

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(ci): enable cfa #9470

wants to merge 9 commits into from
+370 −50

Conversation

stormslowly
Copy link
Contributor

@stormslowly stormslowly commented Feb 26, 2025 •
edited
Loading

Summary

  1. copy original release full yaml file, use seperate OTP_NPM_TOKEN for cfa
  2. add --otp option in workflow
  3. opt publish with 4 times try

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@stormslowly stormslowly marked this pull request as draft February 26, 2025 06:07
@netlify Netlify
Copy link

netlify bot commented Feb 26, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit a21ae57
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bfd91ac0ff940008c5ddd9
😎 Deploy Preview https://deploy-preview-9470--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Feb 26, 2025
@stormslowly stormslowly changed the title feat(ci): enable fca feat(ci): enable cfa Feb 26, 2025
@stormslowly stormslowly force-pushed the feat/cfa branch 2 times, most recently from 6f11163 to 35294aa Compare February 27, 2025 02:46
@stormslowly stormslowly marked this pull request as ready for review February 27, 2025 02:55
@stormslowly stormslowly requested a review from hardfist February 27, 2025 02:55
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9470 will not alter performance

Comparing feat/cfa (a21ae57) with main (a6324a0)

Summary

✅ 7 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz is a code owner

@hardfist hardfist Awaiting requested review from hardfist

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stormslowly