Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the reference to process asset stages in examples #9485

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

xbzhang2020
Copy link
Contributor

Summary

When using process assets examples provided by the document, I encountered the following TS error: Property 'PROCESS_ASSETS_STAGE_ADDITIONS' does not exist on type 'Compilation'.

Actually, asset processing stages are exported by compiler.webpack.Compilation instead of compilation. See Webpack docs.

Screenshot 2025-02-27 at 09 40 21

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: document release: document related release(mr only) label Feb 27, 2025
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 19c8ad8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bfc5cc6dd56e00081b1fb6
😎 Deploy Preview https://deploy-preview-9485--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chenjiahan chenjiahan enabled auto-merge (squash) February 27, 2025 05:39
@chenjiahan chenjiahan merged commit a846bba into web-infra-dev:main Feb 27, 2025
30 checks passed
@xbzhang2020 xbzhang2020 deleted the fix-docs-description branch February 27, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: document release: document related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants