Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parse-has-disallow-nesting-has-inside-has.html forgiving selector tests #598

Closed
foolip opened this issue Oct 27, 2023 · 3 comments
Closed
Labels
focus area: :has() test-change-proposal Proposal to add or remove tests for an interop area

Comments

@foolip
Copy link
Member

foolip commented Oct 27, 2023

Test List

https://wpt.fyi/results/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has.html, either the whole test or the subtests ':has(:is(:has()))' and ':has(:where(:has()))'.

Rationale

The tests were added in web-platform-tests/wpt#42314 following a resolution in w3c/csswg-drafts#8356. The spec change hasn't been made yet.

This is a scope change and even with a spec change we can't commit to fixing this in Chrome before EOY.

If we carry :has() over into Interop 2024, then adding the test back there is probably OK. (I'd have to confirm with the team.)

@foolip foolip added test-change-proposal Proposal to add or remove tests for an interop area focus area: :has() labels Oct 27, 2023
@foolip
Copy link
Member Author

foolip commented Oct 30, 2023

The last subtest in parse-has.html ('":has(:is(.a, 123))" should be a valid selector') should also be removed for the same reason.

@foolip
Copy link
Member Author

foolip commented Nov 10, 2023

It's been a while, but summarizing the discussions from #599.

The distilled argument I'm making is that the tests were changed, and if we had reviewed the change ahead of time, we would not have had consensus to expand the scope of Interop 2023 with those new tests, and suggested that the tests be added in some other files.

And the reason we're making the argument is that @lilles's team had already finished the work on this focus area for Interop 2023, so the regression was from 100% to less than 100%.

I probed for objections to us sending a PR to split out these tests, and nobody objected.

I hope and believe that's a fair representation of what was discussed.

@foolip
Copy link
Member Author

foolip commented Nov 16, 2023

This has been resolved now:
web-platform-tests/wpt#43080
web-platform-tests/wpt#43168

@foolip foolip closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: :has() test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

1 participant