Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different number of subtests at top and bottom of results table #3834

Open
foolip opened this issue May 20, 2024 · 3 comments
Open

Different number of subtests at top and bottom of results table #3834

foolip opened this issue May 20, 2024 · 3 comments
Assignees

Comments

@foolip
Copy link
Member

foolip commented May 20, 2024

Looking at https://wpt.fyi/results/compat?run_id=5095555055484928&run_id=5174632751824896&run_id=5155156954185728&run_id=5128162447196160 I see "Showing 31 tests (98 subtests)" at the top of the table, but the Subtest Total at the bottom has numbers like 109 / 119, suggesting 119 subtests.

I would expect these numbers to match. (And when using view=test I'd expect the test counts to match instead.)

@jcscottiii
Copy link
Collaborator

jcscottiii commented May 21, 2024

@foolip For view=test, we can add a conditional to remove the (X subtests) clause if it is the test view. But in test=view the test count (while ignoring the subtest count) is correct.

For the default subtest view, I'm not sure what's going on though for the slightly off error. @DanielRyanSmith, this logic comes from computeResultsTotalsRangeMessage. If not, I can do some deeper looking later this week.

@DanielRyanSmith
Copy link
Contributor

I will be OOO for a few weeks coming up, and I don't think I'll be able to look into this beforehand. Sorry I couldn't be of more help, but I can still assist when I'm back if need be. 🙂

@foolip
Copy link
Member Author

foolip commented May 22, 2024

That's OK, this isn't urgent, it's probably been like this for years. Have good time off, @DanielRyanSmith!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants