From fe8878e4d1416239bbb7cb5e837b15f5f6f8c4c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Thu, 28 May 2020 10:56:06 +0000 Subject: [PATCH] Fix IntersectionObserverEntry.isIntersecting to match other browsers. Note that no browser matches the spec (see https://github.com/w3c/IntersectionObserver/issues/432), but that our behavior is reasonably close to them. So do this to match them. Differential Revision: https://phabricator.services.mozilla.com/D76603 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1611204 gecko-commit: 867528d1d35bdec48758f8aa899b0491d7ef10e5 gecko-integration-branch: autoland gecko-reviewers: mstange --- intersection-observer/isIntersecting-threshold.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/intersection-observer/isIntersecting-threshold.html b/intersection-observer/isIntersecting-threshold.html index 106b65edd7525d..842c8e2c9f96de 100644 --- a/intersection-observer/isIntersecting-threshold.html +++ b/intersection-observer/isIntersecting-threshold.html @@ -43,7 +43,8 @@ assert_equals(entries.length, 2); assert_true(entries[1].intersectionRatio >= 0.5 && entries[1].intersectionRatio < 1); - assert_equals(entries[1].isIntersecting, true); + // See https://github.com/w3c/IntersectionObserver/issues/432 + assert_equals(entries[1].isIntersecting, false); scroller.scrollTop = 100; }