From da71b6aa0698b85c5f892f3990c757cfd883f7f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Thu, 22 Oct 2020 08:38:11 +0000 Subject: [PATCH] Fix more IntersectionObserver issues. Two spec issues here. https://github.com/w3c/IntersectionObserver/issues/457: I think this is just a spec bug and I've made us match other browsers, but since the tests don't match the spec for now I've added them as .tentative.html https://github.com/w3c/IntersectionObserver/issues/456: I've aligned with WebKit here. There was a (disabled) test for this which tests chrome behavior and which after this patch shouldn't be flaky. This is what was causing the assertion. Differential Revision: https://phabricator.services.mozilla.com/D93166 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1670327 gecko-commit: 2906a77771b3abcc15c2859052c0d170b263133d gecko-reviewers: hiro --- ...cit-root-different-document.tentative.html | 27 +++++++++++++++++++ ...t-in-containing-block-chain.tentative.html | 25 +++++++++++++++++ .../target-in-different-window.html | 4 +++ 3 files changed, 56 insertions(+) create mode 100644 intersection-observer/explicit-root-different-document.tentative.html create mode 100644 intersection-observer/not-in-containing-block-chain.tentative.html diff --git a/intersection-observer/explicit-root-different-document.tentative.html b/intersection-observer/explicit-root-different-document.tentative.html new file mode 100644 index 00000000000000..15c5e620d5beaa --- /dev/null +++ b/intersection-observer/explicit-root-different-document.tentative.html @@ -0,0 +1,27 @@ + + + + + + +
+ diff --git a/intersection-observer/not-in-containing-block-chain.tentative.html b/intersection-observer/not-in-containing-block-chain.tentative.html new file mode 100644 index 00000000000000..4490d0b631ec2e --- /dev/null +++ b/intersection-observer/not-in-containing-block-chain.tentative.html @@ -0,0 +1,25 @@ + + + + + + +
+
+ diff --git a/intersection-observer/target-in-different-window.html b/intersection-observer/target-in-different-window.html index 645b7ec1908cc2..fcf5ba94372bea 100644 --- a/intersection-observer/target-in-different-window.html +++ b/intersection-observer/target-in-different-window.html @@ -1,5 +1,9 @@ +