Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Picker - Dismiss keyboard when changing from keyboard to clock mode #438

Closed
YusufRSU opened this issue Jan 7, 2025 · 4 comments
Closed
Assignees
Labels

Comments

@YusufRSU
Copy link

YusufRSU commented Jan 7, 2025

Is your feature request related to a problem? Please describe.
A user of our app brought up that it is confusing that the keyboard remains up when they switch from the keyboard time entry mode to the mode with the big clock for tapping time entry. After looking into it, I don't see a way to adjust this myself

Describe the solution you'd like
A new option to dismiss the keyboard when changing from keyboard entry to clock entry mode would be great. I say option in case this is operating as intended right now

Describe alternatives you've considered
As it isn't a breaking issue we haven't tried any major workarounds. But if there was a way to add custom code to fire when the mode switch is pressed that would have been nice.

Additional context
image

@RichardLindhout
Copy link
Member

RichardLindhout commented Jan 7, 2025

PR is welcome, Keyboard.dismiss onPress would be ok (in package itself)

@iM-GeeKy iM-GeeKy added the stale label Jan 18, 2025
@iM-GeeKy iM-GeeKy self-assigned this Jan 31, 2025
@iM-GeeKy
Copy link
Collaborator

@YusufRSU #450 will close this once merged 👍🏻

@YusufRSU
Copy link
Author

Awesome, thank you

@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented Feb 1, 2025

Closed by #450

@iM-GeeKy iM-GeeKy closed this as completed Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants