Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question Metrics labels #20

Open
vyckou opened this issue Mar 10, 2020 · 0 comments
Open

Question Metrics labels #20

vyckou opened this issue Mar 10, 2020 · 0 comments

Comments

@vyckou
Copy link

vyckou commented Mar 10, 2020

Hi,

Thanks for the initiative, nicely written golang, only unittests missing 😉

I was trying out the exporter and checking the metrics, while question araised regarding labels for the metrics and before changing the behaviour wanted just to doublecheck, whenever I am missing anything

for example I have a metric azure_devops_repository_info. Metric example smth like:

azure_devops_repository_info{instance="host.docker.internal:8080",job="prometheus",projectID="fb540d14-e477-487a-8af2-a152aa0a328f",repositoryID="03124f65-c354-4fb6-aeba-956e3f43ccc4",repositoryName="HubDetect"}

I assume, that this ☝️ metric is for keeping the linkage between repositoryID and repositoryName and carries data about to which project repo belongs to

then I have azure_devops_project_info metric, as example

azure_devops_project_info{instance="host.docker.internal:8080",job="prometheus",projectID="fb540d14-e477-487a-8af2-a152aa0a328f",projectName="DIGMOWEB_POC"}     1

☝️ this metric seems like only to keep the linkage between projectID and projectName

then I have azure_devops_repository_commits metric, where I have a real metric about commits made to repository in ADO
example of the metric:

azure_devops_repository_commits{instance="host.docker.internal:8080",job="prometheus",projectID="fb540d14-e477-487a-8af2-a152aa0a328f",repositoryID="03124f65-c354-4fb6-aeba-956e3f43ccc4"}	0

azure_devops_repository_commits metric labels projectID and repositoryID for out of the box, doesnt say a lot, so seems, I need to leftjoin azure_devops_repository_commits metric with azure_devops_repository_commits and azure_devops_project_info

The question - why you are not placing the repoName together with ProjectName to the azure_devops_repository_commits metric in the first place and removing the need of left_joins in prometheus?

Same applies not only for azure_devops_repository_commits, but also for azure_devops_repository_stats, azure_devops_repository_pushes etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant